When viewing with Firefox eveything works OK, however with IE7 the browser reports an error on line 9 of the js_theming.js file. The error is: "'Drupal.messages' is null or not an object."

CommentFileSizeAuthor
#7 ie7.patch345 bytessandfurz

Comments

ibergmark’s picture

ibergmark commented

eveything = everything :-D

reg’s picture

reg commented

Same here, did you find a solution?
Subscribing.

reg’s picture

reg commented

Just realized that I installed it but never used it. When I disabled the module no more IE7 errors.

sandfurz’s picture

sandfurz commented

got it ..
just delete the comma in line 144 of js_theming.messages.js

litwol’s picture

litwol commented
Status: Active » Postponed (maintainer needs more info)

@sandfurz,

Can you create a patch? i checked my files and i only have a comma on line 140, but i would like to make sure we're talking about the same one before i remove it from the module.

sandfurz’s picture

sandfurz commented

oops ... I see, maybe I produced some blanks in top of my file while experimenting - sorry :-)

But it's pretty clear to me now:
It's the very last comma, after function "prune" - which is already the last member of the js-object and therefore no other comma is needed. IE doesn't seem to be as tolerant es firefox in that aspect.

sandfurz’s picture

sandfurz commented
StatusFileSize
new ie7.patch345 bytes
jpmckinney’s picture

jpmckinney commented

The last trailing comma in js_theming/js_theming.table.js also needs to be removed.

jpmckinney’s picture

jpmckinney commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

The patch in #7 and the fix in #8 solves IE 7 issues. Both relate to trailing commas. Please commit the changes.

litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Fixed

Committed to -dev. thanks guys. If you have more patches for features or anything, let them come :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.