I have been working with the MM_CCK as I had problems trying to get a video file from a fielfield cck, convert it into a flv with mm_ffmpeg and saving it into another cck filefield. The same creating thumbnails, taking a video file from a cck filefield, and storing the thumbnail into a cck imagefield.
With this patch all this combinations work fine.

I comment some fixes that could apply to the 6.x version.

1- Filefield CCK fields case for files is file not filefield

2. file timestamp doesn't exist in drupal 5.x so I take original functions in old 5.x-dev versions.

3. To get all the needed fields in this module calling content_fields is needed the second content type argument.
As a suggestion, it could be nice to have the option to configure not only the CCK field but also from which content type. This would allow to have different actions for different content types - for example different ffmpeg transformation depending of content type. That even would allow to use this content type into the content_fields function and avoid a double call.

4. To store the file into the CCK field I use the filefield and imagefield modules function that inserts the files, and I create the required file for each case (there are some differences between imagefield and filefield). That should be the same for 6.x.

5. fixed some names from old mm_content module

Other suggestion would be having a delete action for the cck and ffmpeg modules, that would be great in order to delete the original files and also clean the mm_ffmpeg temporal directory.

CommentFileSizeAuthor
#1 mm_cck.module.patch4.17 KBjcmarco

Comments

jcmarco’s picture

StatusFileSize
new4.17 KB

The patch file

arthurf’s picture

I took some of your ideas and tried to cleanup some of the aspects of the dependencies- I'd rather that the module doesn't depend on image or file field, but can detect them if they are enabled, so I've put that functionality in place. I still need to do some testing on the refactoring, but I think things are finally getting shored up from my D6 backport disaster.

jcmarco’s picture

Hi Arthur,
Congrats for all your projects, they are awesome!. We are migrating from D5 to D6 so I have started migrating and testing all the stuff done with D5 versions, thus from now, I will try to focus in D6 versions of: SWFObjet_API, FLV_Media_player, Media_Mover, Ffmpeg_Wrapper, XSPF, ... (and much more other ones).
All your code is really well organized once you understand the API and the structure, so I am using most of the parts to fix the others.
But possibly I couldn't help too much testing backportings. We decided to start migrating when I realized that few people was doing patches, fixes, or upgrades to D5 versions of most main modules. I am also following all the job done in Media, as it looks to be the future to integrate many multimedia modules that are running for everywhere.