Incorrect implementation of link_alter

From #321295: Errors when other modules incorrectly implement link_alter I did a search for modules that incorrectly implement link_alter. panels 6.x-2.x is one of the offenders. The docs for hook_link_alter say that the function should be passed $links, then $node (a reversal from D5). You can see an example of the correct implementation of node_view. Your implementation currently passes the parameters in reverse.

Current 6.x-2.x code in panels/content_types/node_content.inc:

function panels_admin_node_content($node, $conf) {
  ...
  if ($conf['links']) {
    $node->links = module_invoke_all('link', 'node', $node, $conf['teaser']);

    foreach (module_implements('link_alter') AS $module) {
      $function = $module .'_link_alter';
      $function($node, $node->links);
    }
  }

Correct version:

function panels_admin_node_content($node, $conf) {
  ...
  if ($conf['links']) {
    $node->links = module_invoke_all('link', 'node', $node, $conf['teaser']);
    drupal_alter('link', $node->links, $node);
  }

Attached patch against current 6.x-2.x that fixes the parameter order and uses drupal_alter, which is the preferred implementation in core (see the link to node_view above). Please also note that there is the same code in the 6.x-3.x version, but it looks like that code is not active.