On some installations, people use a different default language without prefix. That is: site with no prefix -> hebrew/spanish/japanese/whatever, and "en" for english.

The attached patch fixes this issue, by changing the SQL to return the path perfix + name, and adjusting all needed code. The indentation of this code is a mess, so the best practice should be to add a new patch to reformat this code... but this will happen only after this bug gets integrated.

The bug is marked as critical, since it breaks my site. Hope this is the correct definition ;-)

CommentFileSizeAuthor
#1 languageinterface-add-prefix2.patch4.46 KBelcuco
languageinterface-add-prefix.patch4.46 KBelcuco

Comments

elcuco’s picture

elcuco commented
StatusFileSize
new languageinterface-add-prefix2.patch4.46 KB

updated patch... this time I added no new lines (used the original if style) and I did the diff the correct way (last patch was reversed...)

PixelClever’s picture

PixelClever commented
Status: Active » Fixed

This should be fixed in version 1.4. I had to make some changes in the patch as it was sending an empty value in the first element of the url array. It now works on my test site, but I am not going to be able to set up a Japanese test site to see if all is well. The indentation should be fixed in this version as well.

elcuco’s picture

elcuco commented

Now I look into my site, which uses the new version of this module and I get this path from the flags (he=default,no prefix, en=second language)

http://zeus/eco/eco/
http://zeus/eco/en/eco/

It seems the logic in language_link_creation() is completely borked. Should I open a new issue? or should we continue using this one?

SaxxIng’s picture

SaxxIng commented
Version: 6.x-1.2 » 6.x-1.4

Same problem to me too! (with 1.2 version there wasn't this problem!)

elcuco’s picture

elcuco commented
Status: Fixed » Active

I have opened the bug once more, since 1.4 is borked (confirmed by 2 people). Again, marked as critical since now it REALLY messed up sites.

jferjan’s picture

jferjan commented

Same problem here.

subscribing

PixelClever’s picture

PixelClever commented
Status: Active » Fixed

Sorry about that guys I had a lot on my plate and couldn't set time aside to work on this module. I shouldn't have committed that first patch without testing thoroughly. It made more changes in the code than were necessary and I didn't see all of the implications until today when I opened it up again to use for a site.

I am finding there is still an issue when dealing with non English original languages... I am going to work on this some more.

PixelClever’s picture

PixelClever commented

The 1.6 release caught something that showed up on one of my test servers... I think it might have been a module incompatibility issue, but at any rate it is the cleaner release.

PixelClever’s picture

PixelClever commented

By the way, I am going to be watching this issue more closely now so let me know if the 1.6 release has any problems.

elcuco’s picture

elcuco commented

Thanks, seem to be working from first, and second look.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.