The insert block help makes a fatal error:
Fatal error: Unsupported operand types in includes\common.inc on line 1275

the problem is that the url() function in the insert_block_help() hook uses D5 parameters.

insert_block.module line 41

      return t('<p>Inserts the contents of a block into into a node using [block:module=delta] tags.</p><p>You may use <a href="@insert_block_help">[block:<em>module</em>=<em>delta</em>] tags</a> to display the contents of block <em>delta</em> for module <em>module</em>.</p>', array("@insert_block_help" => url("filter/tips/$format", NULL, 'filter-insert_block')));

should be changed to

      return '<p>'. t('Inserts block content into a node using [block:module=delta] tags.') .'</p>';

Comments

basicmagic.net’s picture

hi and thanks for a great module-

i saw this, too... when i tried to go to:
http://yourdrupalsite.com/admin/help

it triggered this error:
Unsupported operand types in html/drupal/includes/common.inc on line 1369

however-
i fixed it using the code, below.

please review and see if it works / is ok!

before (broken):

return t('<p>Inserts the contents of a block into into a node using [block:module=delta] tags.</p><p>You may use <a href="@insert_block_help">[block:<em>module</em>=<em>delta</em>] tags</a> to display the contents of block <em>delta</em> for module <em>module</em>.</p>', array("@insert_block_help" => url("filter/tips/$format", NULL, 'filter-insert_block')));

after (working):

return t('<p>Inserts the contents of a block into into a node using [block:module=delta] tags.</p><p>You may use <a href="@insert_block_help">[block:<em>module</em>=<em>delta</em>] tags</a> to display the contents of block <em>delta</em> for module <em>module</em>.</p>', array("@insert_block_help" => url("filter/tips/$format", array('query' => NULL, 'fragment' => 'filter-insert_block'))));
mlsamuelson’s picture

Status: Needs review » Fixed

Thanks for tracking this down. I've corrected for the issue and cleaned up the filter tips and help page text while I was at it.

The updates are in both HEAD and the 6-1.x branch.

Much appreciated.

mlsamuelson

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

  • Commit 043ce09 on 6.x-1.x, 8.x by mlsamuelson:
    #350097 thanks Pasqualle and basicmagic.net - fixing url() parameter...
  • Commit 4a4688e on master, 8.x by mlsamuelson:
    committing to head #350097 thanks Pasqualle and basicmagic.net - fixing...

  • Commit 043ce09 on 6.x-1.x, 8.x, 8.x-1.x by mlsamuelson:
    #350097 thanks Pasqualle and basicmagic.net - fixing url() parameter...
  • Commit 4a4688e on master, 8.x, 8.x-1.x by mlsamuelson:
    committing to head #350097 thanks Pasqualle and basicmagic.net - fixing...