Hi,
I noticed that custom signup data doesn't get translated. The attached patch inserts t() in theme_signup_custom_data($data) and theme_signup_custom_data_rows($data).

CommentFileSizeAuthor
#1 signup.module.patch540 bytesolio
signup.module.patch625 bytesolio

Comments

olio’s picture

olio commented
StatusFileSize
new signup.module.patch540 bytes

Oops!
I'm sorry, but I posted the wrong patch... Here is the correct one! (Only the $key element needs translation in both functions).

dww’s picture

dww
we/he/they
commented
Category: bug » support
Status: Needs review » Closed (duplicate)

A) You don't understand how t() works. You can't put variables in there like this.

B) This request is duplicate: #181272: can't translate labels on the signup form?

olio’s picture

olio commented

Oh, very polite reply ...
Anyway, in my case it works - so far my understanding of t() seems to be sufficient.

dww’s picture

dww
we/he/they
commented

@olio: Sorry, I've been pretty heavily jetlagged the past few days -- traveling for the holidays. And, I deal with *a lot* of duplicate issues, so I'm a little harsh about that sometimes. ;)

Anyway, I re-read the API docs for t() and discovered there's an edge-case where using a variable inside t() is ok (even though the potx.php extractor throws error messages if you do it). See #181272-2: can't translate labels on the signup form?.

Cheers,
-Derek

olio’s picture

olio commented

Hi Derek,

thanks for your replies and explanations! Up to now, I only read the API docs for Drupal 5, not those for Drupal 6 where usage of variables inside t() is better explained. Definitely I should broaden my horizont to D6 (my first New Year's pledge). ;o)

Thanks again,
Oli