The skeleton edit page is almost unusable in it's current state. Text runs into each other, and it's not really clear what you're supposed to do. See the attached screen shot for how it looks using zen_classic.

Off the top of my head:

  • Combo boxes should have labels.
  • Something needs to separate each template assigned to the skeleton
  • The save button should be at the bottom
  • The form should use horizontal space in a better manner
CommentFileSizeAuthor
#1 350328_skeleton_edit_page_1.patch14.15 KBdeviantintegral
#1 skeleton_edit_form_1.png66.08 KBdeviantintegral
Skeleton Edit Screen.png49.01 KBdeviantintegral

Comments

deviantintegral’s picture

deviantintegral commented
Status: Active » Needs review
StatusFileSize
new skeleton_edit_form_1.png66.08 KB
new 350328_skeleton_edit_page_1.patch14.15 KB

Here is a patch which redoes most of the skeleton form. Changes include:

  • Implemented hook_theme() for Drupal 6. Apparently the Coder module missed this, and this was causing the tables not to be rendered for the form.
  • Moving all of the form rendering into the theme function, and ensuring that only FAPI work is done in the form function itself.
  • Add columns to indicate the language of templates if the translation module is enabled.
  • Change the form structure so it's possible to identify "available templates" from "current templates". There's probably some more refactoring which can be done.
  • Move the "action links" for creating and deleting the skeleton to buttons at the bottom, just like nodes.
  • When editing a node template, saving the template returns you to the skeleton form.
deviantintegral’s picture

deviantintegral commented
Status: Needs review » Fixed

Applied to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.