Download & Extend
Skeleton outlines » Issues

Clean up Skeleton edit page

Posted by deviantintegral on December 23, 2008 at 12:35am
Project:Skeleton outlines
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The skeleton edit page is almost unusable in it's current state. Text runs into each other, and it's not really clear what you're supposed to do. See the attached screen shot for how it looks using zen_classic.

Off the top of my head:

  • Combo boxes should have labels.
  • Something needs to separate each template assigned to the skeleton
  • The save button should be at the bottom
  • The form should use horizontal space in a better manner
AttachmentSize
Skeleton Edit Screen.png49.01 KB
Login or register to post comments

Comments

#1

Posted by deviantintegral on December 23, 2008 at 2:42am
Status:active» needs review

Here is a patch which redoes most of the skeleton form. Changes include:

  • Implemented hook_theme() for Drupal 6. Apparently the Coder module missed this, and this was causing the tables not to be rendered for the form.
  • Moving all of the form rendering into the theme function, and ensuring that only FAPI work is done in the form function itself.
  • Add columns to indicate the language of templates if the translation module is enabled.
  • Change the form structure so it's possible to identify "available templates" from "current templates". There's probably some more refactoring which can be done.
  • Move the "action links" for creating and deleting the skeleton to buttons at the bottom, just like nodes.
  • When editing a node template, saving the template returns you to the skeleton form.
AttachmentSize
350328_skeleton_edit_page_1.patch 14.15 KB
skeleton_edit_form_1.png 66.08 KB

#2

Posted by deviantintegral on December 28, 2008 at 10:45pm
Status:needs review» fixed

Applied to HEAD.

#3

Posted by System Message on January 11, 2009 at 10:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.