settings.inc, node interface and UTF-8 issues

Oops, I tried to mask the original path when posting for security, but unfortunately I have missed tha last one, no confusion please, all paths are same on all errors in fact :/

Newly, I tried to uninstall/reinstall FC and I enabled all FC modules except webforms. Then I discovered that no fusioncharts related SQL tables are created during module enable also.

I also tried to install on a sandbox account on DrupalValueHosting (Drupal 6.6) other than our server, but no success again. When I tried to create a chart node, I got this time not a blank; but a page with a single error line:

Fatal error: Call to undefined function _fusioncharts_settings_subform() in /home/yavyavco/public_html/sites/all/modules/fusioncharts/fusioncharts_node/fusioncharts_node.module on line 229

Though Fusion Charts Demos are working properly on both servers.

Thanks, yes path problem goes away by this hack, but second problem persists.

I searched all install procedures (root and FCnode dir) and have not seen any SQL related CREATEs or something, and checked old versions of the code and find one eventually on one of the 5.x-dev packages, perhaps the initial release.

I copied the CREATESs with a little hope to 6.x-dev module.install and reinstalled again, this time I had the table with the name "fusioncharts" in place. But when I tried to create a node, module complained again and said that table "fusioncharts_node" was not present. I changed the name of the table to match the error with a little hope again but no way. Only table error disappeared but second long error in msg #1 have persisted.

I am not sure why there are no table creates anywhere in 6.x-dev.

Do we need an upgrade path from somewhere, D5+F5 -> D6+FC6 or something?

Thank you in advance.

I tried zillion times to uninstall/reinstall FC previously but database tables had been created neither on D6.6 nor on D6.8, but after installing Schema API, FC installed correctly for the first time.

Is there any dependency with Schema API module? May be something goes wrong with native Drupal 6.x schema or we may have our own problems with our Drupal installations.

Can anyone reproduce this?

Anyway I got my first chart, but there are many JS errors together with the secondary long error in #1. If I can decode the chaotic behaviour (esp.FC node), I plan to file them under a seperate issue.

Thanks for a great module by the way.

Thank you for your efforts aaron, I am experimenting with the new dev version now.

By the way, does the module handle multibyte UTF-8 characters correctly? Seems not.

Somebody says something like Writer writer = new OutputStreamWriter(outs, "UTF-8"); on FCF forum :S

May it be easy!

Ok, just a note.

When I try to add a CCK field, configuration page complains with the following error:

    * "Width" must be a positive integer.
    * "Height" must be a positive integer.
    * "Width" must be a positive integer.
    * "Height" must be a positive integer.

And I know there is an API but err.. any plans for a [fusion:node=1] or something :)

Tx.

Hello, I want to share initial results with the new dev on Drupal 6.8. I reinstalled module from scratch as Drupal complained that fusioncharts_cck_fields table is not present. After uninstall/reinstall, this error has gone.

CCK:

When you create a cck field configuration page comes ok but following error is introduced:

    * warning: array_unshift() [function.array-unshift]: The first argument should be an array in /sites/all/modules/fusioncharts/fusioncharts_node/matrix.inc on line 29.
    * warning: Invalid argument supplied for foreach() in /sites/all/modules/fusioncharts/fusioncharts_node/matrix.inc on line 69.

Then when you save the conf, D says:

# warning: Attempt to assign property of non-object in /sites/all/modules/fusioncharts/settings.inc on line 12.
# warning: Attempt to assign property of non-object in /sites/all/modules/fusioncharts/settings.inc on line 15.
# warning: Attempt to assign property of non-object in /sites/all/modules/fusioncharts/settings.inc on line 12.
# warning: Attempt to assign property of non-object in /sites/all/modules/fusioncharts/settings.inc on line 15.

but saves successfully

When you create a node type with this CCK field included, no chart is shown. Neither for preview, nor after saving. No errors shown also. Then when you edit the same node, you see that the FC data grid loses its values. Refill and resave does nothing again.

FC Node:

Partially good news now :)

When you create a native FC node without changing chart type, your chart is created succesfully, no problems. You have a very nice Column 3D bar chart with labels, everything is intact.

If you try to change the chart type from dropdown field, first an alert window says:

An HTTP error 0 occurred. 
/fusioncharts/js/chartsettings

then second time you select, type is selected correctly and when you save you get your new type of chart. Also if you select a previously selected chart type again, alert window does not appear, everything works as expected. When you save you have your chart with the new type.

Big problem is if you want to preview the node. If you press preview you get:

* warning: sort() expects parameter 1 to be array, null given in /sites/all/modules/fusioncharts/fusioncharts.module on line 55.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: htmlentities() expects parameter 1 to be string, array given in /sites/all/modules/fusioncharts/fusioncharts.module on line 67.
    * warning: Invalid argument supplied for foreach() in /sites/all/modules/fusioncharts/fusioncharts.module on line 230.

with no chart preview, but data is intact on the grid. If you save the node all you got a chart with "no labels" on it, just floating bars. Do whatever you want, edit, change values, add rows; all you get is a "not labeled" chart with bars only. You have to delete and create a new FC node and avoid "preview" this time :S

Chaos:

Sometimes when you try to change the type on FC node, another data input grid appears under somewhere on edit page with the same input data on it. May be some hidden form values are exposed erroneously when JS callbacks server, or data grid field is attached twice somehow after type change. Eventually this error seems chaotic, it seems to appear randomly. By the way I am using FireFox 3.0.5.

UTF-8

Labels can have UTF-8 characters now, thanks for fixing :)

This is my test. All errors can be specific to our setup, but I hope this helps.

Thank you for your efforts.

Minor update.

Multiseries charts saves successfully but if you try to edit, they lose all additional columns except the first two. Also if you add columns, row orders change from "Label 1 2 .." to "1 2 3..". But first row retains its label functionality.

When first creating a node, if you input values and missed something required on the node edit form then you save, you lose all your input when page refreshes and warns you about the missing field (e.g. Title).

Tx.

Ok, first reproduce the HTTP 0 and double data grid problem then I will propose a fix at the end:

Create a FC node -> Change chart type to X -> Get your http error 0 press OK -> Chart type didn't changed yet, select type X again -> Refresh page (F5) -> Say OK to resend form values.

Voila, you will have another data grid somewhere under the node form and this is the main grid from now on. Fill two grids, save node, and chart results will be the one's under.

Let's come to JS, by the way there is no id named "#edit-major-type" in D6.8 or any other modules that we have.

	  $('select#edit-major-type').change(function() {
	    $('form#node-form').get(0).submit();
	  });

So this call in fusioncharts.js is not functioning I am afraid.

And the big news comes last, for "An HTTP error 0 occured" and "double data grid" problem:

Change fusioncharts.js line #7 from

$('form#node-form').get(0).submit();

to

$('form#node-form').get(0).setTimeout(submit,1);

Somehow JS's euphoria causes trample damage but a sedative pill soothes I think :P

I always write things as a whole for clarity because I am not a coder. I can not be sure where to focus in fact, sorry for long posts then.

Hope this helps.

Tx.

Hi again, on CCK side, I discovered something that I am not sure if this is a FC CCK or core CCK (6.x-2.x-dev) issue but will write down anyway.

When trying to asign an existing FC CCK field to a node type, following error comes:

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FROM thg_content_type_page' at line 1 query: INSERT INTO thg_content_field_fusion (vid, nid ) SELECT vid, nid, FROM thg_content_type_page in /sites/all/modules/cck/includes/content.admin.inc on line 1511.

In fact this is because of passing "no" extra column info to core CCK module that breaks the following query on /sites/all/modules/cck/includes/content.admin.inc on line #1510.

db_query('INSERT INTO {'. $new_table .'} (vid, nid, '. implode(', ', $columns) .') '.
        ' SELECT vid, nid, '. implode(', ', $columns) .' FROM {'. $previous_table .'}');

Though CCK creates "content_field_fusion" table (I gave the name 'fusion' to field), the above query fails because of the "vid,nid," trailing comma (,) problem as no column info is passed to the imploder. "fusioncharts_cck_fields" table is present and intact also with all necessary data in it.

phpMyAdmin reports for corresponding line on table "content_node_field":

field_fusion  	fusioncharts  	a:0:{}  	0  	0  	0  	fusioncharts_cck  	a:0:{}  	1  	

and some attempts of my data input on content_node_field_instance as:

field_fusion  	page  	45  	Fusion  	fusioncharts_cck_single_series  	a:2:{s:13:"default_value";a:1:{i:0;a:2:{s:13:"matr...  	a:7:{s:5:"label";a:2:{s:6:"format";s:5:"above";s:7...  	   	fusioncharts_cck  	1
field_fusion 	story 	32 	Fusion 	fusioncharts_cck_single_series 	a:2:{s:13:"default_value";a:1:{i:0;a:2:{s:13:"matr... 	a:7:{s:5:"label";a:2:{s:6:"format";s:5:"above";s:7... 	  	fusioncharts_cck 	1

As I can see from a:0:{} for "db_columns" column on "content_node_field", there is no column value for FC.

I am not sure if this is a FC CCK or core CCK or a local issue by the way.

Thank you.

Aha, then I have broken the broken part. If I break smt, I will post here again :) You're welcome.

I expect good news for CCK also, and err.. a filter to put charts in node bodies will be amazing (like image_assist). Same chart could be used multiple times with this and updates would be a child's play. This will be a revolution in charts history :P

I think Views->Block-in-node and/or Panels workaround is serpentine, and CCK is too much node centric.

I try to sound you out on this before a feature request by the way :)

Tx.

Hi again,

fusioncharts.module line #68

$str_xml .= " ". $key ."='". htmlentities($value, ENT_QUOTES, 'UTF-8') ."'";

gives the

warning: htmlentities() expects parameter 1 to be string, array given in /var/www/html/beta.thgtr.com/sites/all/modules/fusioncharts/fusioncharts.module on line 68.

error when one tries to preview the FC node.

After changing the line to this (

$str_xml .= " ". $key ."='". (gettype($value) == 'string' ? htmlentities($value, ENT_QUOTES, 'UTF-8') : $value) ."'";

,the error disappears. (See *edit, above is nonsense)

Albeit preview shows no chart at all.

Tx.

*edit: Oops, $value comes as an array itself as warning says. I monkeyed with smt like this:

if(is_array($value)) {
	  $value = array_map(create_function('$str', 'return htmlentities($str,ENT_QUOTES,"UTF-8");'),$value);
	  foreach($value as  ...

Then I am lost :/