SQLite test failures [#350545]

The new invalid date tests added in #344575: Force MySQL to run in ANSI compatability mode. are failing on SQLite (3.4.2).

Insert with zero as month in date unexpectedly succeeded.	Other	database_test.test	2037	DatabaseInvalidDataTestCase->testInvalidDate()	
Insert with zero as day in date unexpectedly succeeded.	Other	database_test.test	2050	DatabaseInvalidDataTestCase->testInvalidDate()	
Insertion of zero date unexpectedly succeeded.	Other	database_test.test	2063	DatabaseInvalidDataTestCase->testInvalidDate()

Comment	File	Size	Author
#5	350545-remove-date-tests.patch	2.39 KB	damien tournoud
#2	350545-remove-date-tests.patch	3.76 KB	damien tournoud

Comments

Comment #2

damien tournoud commented 3 January 2009 at 14:49

Status:

Active

» Needs review

Status	File	Size
new	350545-remove-date-tests.patch	3.76 KB

I suggest we remove them. Neither date and time types nor their associated functions are not consistent across databases, and we can't support them correctly.

Comment #3

8 January 2009 at 01:00

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #4

damien tournoud commented 11 January 2009 at 01:21

Status:

Needs work

» Needs review

Test bed glitch.

Comment #5

damien tournoud commented 11 January 2009 at 22:16

Status	File	Size
new	350545-remove-date-tests.patch	2.39 KB

I was heavy handed in the first patch. Only the date test has to be removed.

Comment #6

Crell commented 12 January 2009 at 00:54

After discussion with Damien in IRC, we agreed that it's probably best to remove this test for now as it is not passable in SQLite. We should then separately look into how if at all we can support native date handling, for which we'd want to loop in KarenS and our other dating experts. So +1 to this patch. Visually it looks fine, as it's just changing a string and killing a test method, so commit as soon as the bot approves.