Update function doesn't work

I will investigate on this, but first I must resolve an issue caused by the editor I was using to commit the changes directly from it.

Like first thought I would think there is something wrong in the code; if it's not that the case, maybe there are some queries that require too much time to be executed, and that need to be split.

My entire site is now non-functional due to this issue. Might I add this is also the second time in a little over a month this has occured with the xml sitemap module.

it is in -dev, so it should be expected. different programmers have different policies when it comes to -dev, some use it just for tested code and have very rarely brake but others sends out every change they do, not always checking it, and then fixes it in next -dev.

I got the same error btw

By definition a development snapshot, that the releases page calls also nightly development snapshot is not stable code. In some cases, it can be stable enough to not produce big problems, but that is a lucky situation possible when the development snapshot is derived from a stable release that has been changed to introduce new features.
XML Sitemap 6.x-1.x-dev is a port of code from the 5.x-2.x-dev which has been converted for Drupal 6, but it has been also changed to correct some problems in the code.

The sentence but there shouldn't be anything committed that could potentially break the code is not applicable to development snapshots, because if that would be true than the version would already be a stable release, and therefore would be an official release.

I tried submitting in once all the changed code, but it is more difficult to do that than it seems. It would be also not practicable, especially when the code is being created in cooperation between more people; if somebody else commits code before I completed the big change I am making, when I try to commit my code I could not (because the local copy is not updated); I would then update my copy of the files, and then change back the code.

This issue has been set like postponed because I had before to verify all the code recently committed; it will be changed to active only when I am sure I corrected any problems caused by the editor I was using.
Please do not change the status, if you don't develop the project code. Thanks.

I agree on that, I doesnt need to be finished, just stable.

I started to work on this project because I wanted to make a stable release for Drupal 6 to use on my web site. I could have simply changed the copy I had, but I decided to make available to anybody else my work.

It's not the right place to list all the issue that must be resolved, but it's that easy to port the code from the Drupal 5 branch, correct the code for Drupal 6, and try to fix the issue that others see using the project modules in their web sites (even if I cannot duplicate them on the test site).
If sometimes my code is not perfect, I ask apologies; code is not something static that can always work in all conditions, and I will do my best to avoid any problems.

I change the status of this issue to resolved. The changes I made in CVS should be already available on the last tarball, or they will be in the next two hours.

I just ran update.php for the latest DEV and got these errors/results:

* user warning: Can't DROP 'PRIMARY'; check that column/key exists query: ALTER TABLE xmlsitemap_file DROP PRIMARY KEY in ../includes/database.mysql-common.inc on line 386.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: ALTER TABLE xmlsitemap_file CHANGE fid `fid` INT unsigned NOT NULL DEFAULT 0, ADD in ../includes/database.mysql-common.inc on line 520.

The following queries were executed

xmlsitemap module
Update #6109

* No queries

Update #6110

* No queries

Update #6111

* No queries

Update #6112

* ALTER TABLE {xmlsitemap} CHANGE loc `loc` VARCHAR(255) NOT NULL DEFAULT '', ADD PRIMARY KEY (loc)
* ALTER TABLE {xmlsitemap} ADD `module` VARCHAR(255) NOT NULL DEFAULT '', ADD INDEX link_module (module)
* ALTER TABLE {xmlsitemap} ADD `type` VARCHAR(32) NOT NULL DEFAULT '', ADD INDEX link_type (type)
* ALTER TABLE {xmlsitemap} ADD `id` INT unsigned NOT NULL DEFAULT 0
* ALTER TABLE {xmlsitemap} ADD `sid` INT unsigned NOT NULL DEFAULT 0
* ALTER TABLE {xmlsitemap} CHANGE lastmod `lastmod` INT unsigned NOT NULL DEFAULT 0, ADD INDEX link_changed (lastmod)
* ALTER TABLE {xmlsitemap} CHANGE changefreq `changefreq` INT unsigned NOT NULL DEFAULT 0
* ALTER TABLE {xmlsitemap} CHANGE priority `priority` FLOAT NOT NULL DEFAULT 0.5, ADD INDEX link_priority (priority)
* DELETE FROM {cache_page} WHERE cid LIKE '%%gss.xsl' OR cid LIKE '%%sitemap%%.xml'
* UPDATE DRUPAL MENUS

xmlsitemap_engines module
Update #6101

* UPDATE MODULE SETTINGS

xmlsitemap_file module
Update #6104

* Failed: ALTER TABLE {xmlsitemap_file} DROP PRIMARY KEY
* ALTER TABLE {xmlsitemap_file} DROP KEY fid_nid
* Failed: ALTER TABLE {xmlsitemap_file} CHANGE fid `fid` INT unsigned NOT NULL DEFAULT 0, ADD
* ALTER TABLE {xmlsitemap_file} CHANGE nid `nid` INT unsigned NOT NULL DEFAULT 0, ADD UNIQUE KEY fid_nid (fid, nid)
* DELETE FROM {xmlsitemap_file} WHERE nid = 0
* UPDATE {system} SET weight = 10 WHERE name = 'xmlsitemap_file'

xmlsitemap_menu module
Update #6102

* DELETE FROM {variable} WHERE name = 'xmlsitemap_menu_custom_menu'
* UPDATE {system} SET weight = 10 WHERE name = 'xmlsitemap_menu'
* DELETE FROM {menu_custom} WHERE menu_name = '1'

xmlsitemap_node module
Update #6101

* UPDATE {system} SET weight = 7 WHERE name = 'xmlsitemap_node'

xmlsitemap_term module
Update #6101

* UPDATE {system} SET weight = 7 WHERE name = 'xmlsitemap_term'

xmlsitemap_user module
Update #6102

* No queries

Update #6103

* No queries

Update #6104

* UPDATE {system} SET weight = 7 WHERE name = 'xmlsitemap_user'

Hey Kiam,

Sorry to further derail this issue. We appreciate your work a lot and I really wish I had the knowledge to assist you.

I think what everyone is saying is that if there were a stable release it would save us the need to use the dev version, which we all agree has no guarantee of working.

If there is anyway in which I can assist you with this please let me know.

@spiffyd: The issue is different from the one in your comment; open a new report.

@harrisben: I understand well that, because it's the same situation I am in.
If you ask me what version of XML Sitemap I am using on my web site, I will tell you I am using the 6.x-0.x-dev version I modified to fix some little issues which would create me problems; this is not because I don't trust my work, but because objectively I prefer to use my version when is really more stable.

Just a couple of warnings more on latest 6.x-1.x-dev update from 5.2x:

user warning: Duplicate key name 'link_changed' query: ALTER TABLE xmlsitemap CHANGE lastmod `lastmod` INT unsigned NOT NULL DEFAULT 0, ADD INDEX link_changed (lastmod) in /Users/user/Sites/Drupal/6/includes/database.mysql-common.inc on line 520.

user warning: Duplicate key name 'link_priority' query: ALTER TABLE xmlsitemap CHANGE priority `priority` FLOAT NOT NULL DEFAULT 0.5, ADD INDEX link_priority (priority) in /Users/user/Sites/Drupal/6/includes/database.mysql-common.inc on line 520.

cheers

@marcoBauli: This issue is different from the original one, then you need to open a different report (different error message, different issue).
The fact that it's an error caused in the module update it's not enough to attach the issue to another one that describes a completely different error; if that would be the case, then there would be a single report for every component you can select: the first person would open the report for that component, and all the others will attach their own reports to that first report.

I fixed what I could fix, basing also on a too vague description of the issue.
I think it has been fixed because I don't get the update function to hung up.

If you still getting the issue, you are free to change the status to open.