1) Add a new vocab
2) Load a vocab

My use case - I'm going to make og_vocab integration. When a group is created a new vocab will be created for that group.

Patch will follow.

CommentFileSizeAuthor
#5 350831_5_vocab_actions.patch6.97 KBamitaibu
#4 rules_vocab.patch6.8 KBfago
#3 350831_3_vocab_actions.patch6.84 KBamitaibu
#1 350831_1_vocab_actions.patch6.78 KBamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Active » Needs review
StatusFileSize
new 350831_1_vocab_actions.patch6.78 KB

Patch.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

FYI, #350490: Module clean-up and new features

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
StatusFileSize
new 350831_3_vocab_actions.patch6.84 KB

Fix a notice

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work
StatusFileSize
new rules_vocab.patch6.8 KB

very nice!

I had a short look it. I noted you use array_filter() - however this is post-processing form values. This should happen during the action's form submit handler.

I've already fixed some coding-style issues: there were some tabs in there and a missing space after an if ( - watch out for that.

re-rolled patch attached.

ah - as we now have support for hook_taxonomy we could also add support for vocabularies there.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs work » Needs review
StatusFileSize
new 350831_5_vocab_actions.patch6.97 KB

Moved form processing to submit handler.

Rosamunda’s picture

Rosamunda commented

I´m sorry but where should I apply this patch? The file taxonomy.rules_forms doesn´t exist...
Thanks!

Rosamunda’s picture

Rosamunda commented

Sorry! My bad. Didn´t realized that it was the dev version!

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

you forgot an empty function in the forms.inc - I've removed that. Else it looks fine so I've committed it. But I gave it no additional test, so please do.. ;)

thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mitchell’s picture

mitchell commented
Component: Provided module integration » Provided Module Integrations

Updated component.