Poll results aren't themable
Stefan Nagtegaal - October 24, 2005 - 16:55
| Project: | Drupal |
| Version: | x.y.z |
| Component: | poll.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Stefan Nagtegaal |
| Status: | closed |
Description
The content of the poll block is full of hardcoded HTML. I consider all hardcoded HTML - which isn't inside theme_* functions - as a bug and file bug reports for them..
We should really improve this...
#1
See attached patch...
I tried to make the theme functions as clean as possible, and I think I did a great job..
I also did some code moving, and variable renaming to make it a little easier.
Please review and apply!
#2
Setting correct status...
#3
Looks good. It applies, and it seems to work. I do not havea site with polls, so I cannot see if it breaks existing polls.
A big +1 for the theme functions though. And also for the var_name clean ups (was namevar)
#4
new patch as requested by steven
#5
Tested quite intens, and setting this Ready to commit...
#6
Updated as requested by Dries...
#7
Renamed patch and uploaded new version
#8
Committed to HEAD. Thanks.
#9