Download & Extend
Issues

Poll results aren't themable

Posted by Stefan Nagtegaal on October 24, 2005 at 4:55pm
Project:Drupal core
Version:x.y.z
Component:poll.module
Category:bug report
Priority:normal
Assigned:Stefan Nagtegaal
Status:closed (fixed)

Issue Summary

The content of the poll block is full of hardcoded HTML. I consider all hardcoded HTML - which isn't inside theme_* functions - as a bug and file bug reports for them..

We should really improve this...

Login or register to post comments

Comments

#1

Posted by Stefan Nagtegaal on October 26, 2005 at 9:35am
Title:Poll block isn't themable» Poll results aren't themable
Assigned to:Anonymous» Stefan Nagtegaal

See attached patch...
I tried to make the theme functions as clean as possible, and I think I did a great job..
I also did some code moving, and variable renaming to make it a little easier.

Please review and apply!

AttachmentSizeStatusTest resultOperations
make-poll-results-themable.patch4.45 KBIgnored: Check issue status.NoneNone

#2

Posted by Stefan Nagtegaal on October 26, 2005 at 9:51am
Status:active» needs review

Setting correct status...

#3

Posted by Bèr Kessels on October 26, 2005 at 12:37pm

Looks good. It applies, and it seems to work. I do not havea site with polls, so I cannot see if it breaks existing polls.

A big +1 for the theme functions though. And also for the var_name clean ups (was namevar)

#4

Posted by Stefan Nagtegaal on October 26, 2005 at 3:01pm

new patch as requested by steven

AttachmentSizeStatusTest resultOperations
poll-module-themable.patch4.38 KBIgnored: Check issue status.NoneNone

#5

Posted by Stefan Nagtegaal on October 29, 2005 at 9:28pm
Status:needs review» reviewed & tested by the community

Tested quite intens, and setting this Ready to commit...

#6

Posted by Stefan Nagtegaal on October 31, 2005 at 2:10pm

Updated as requested by Dries...

AttachmentSizeStatusTest resultOperations
make-poll-results-themable_0.patch4.45 KBIgnored: Check issue status.NoneNone

#7

Posted by Stefan Nagtegaal on October 31, 2005 at 2:26pm

Renamed patch and uploaded new version

AttachmentSizeStatusTest resultOperations
poll-themability.patch4.36 KBIgnored: Check issue status.NoneNone

#8

Posted by Dries on October 31, 2005 at 2:28pm
Status:reviewed & tested by the community» fixed

Committed to HEAD. Thanks.

#9

Posted by Anonymous on November 14, 2005 at 2:40pm
Status:fixed» closed (fixed)
nobody click here