First off, thank you for this terrific module! It's great not to have to tie up that valuable front-page real estate with a block anymore!

One problem - it's (probably) small, but I think potentially very important: When using the popup js option, I would suggest that there needs to be a "cancel" button to close the popup window should the user opt not to register. Needing to click the original link to close the window is counterintuitive for many users and being unable to close a window they've just opened could easily be enough to "scare" new potential users away. Not good.

I'm not a coder, but it looks to me like the easiest way to accomplish this would be a hack to the 5.x user module adding the 'cancel' form element and using the Javascript:window.close() command in the function_user_block() at line 493 (Drupal 5.12). Could you (or anyone) possibly provide me with some guidance here? Thanks again for a terrific module - great work!

Comments

hunmonk’s picture

hunmonk commented
Status: Active » Closed (won't fix)

5.x is a stable branch, and i will not accept any new features for it. if you wish, you may reopen the issue for 6.x and we can examine it there.

bcobin’s picture

bcobin commented

Thank you very much for the quick response; unfortunately, there are just too many modules that haven't yet been ported over to D6 yet for me to be able to use it for actual clients, much as I'd like to be able to.

I'll try hacking around on my own and open the issue for D6 when I have a chance; I do think it's a valid point and seems like it should be a fairly straightforward addition. In the meantime, if you should have any suggestions as to the best way to go about this for D5, it would be greatly appreciated!

Thanks again for a great module - keep up the great work!

bcobin’s picture

bcobin commented

Got it! Kudos to the aptly-named ByteSlinger here.

In my case, the line to insert at line 536 of the module is as follows:

$form['cancel'] = array('#type' => 'button','#value' => t('Cancel'),'#attributes' => array('onClick' => "toggleboggan();this.blur();return false;"));

Works like a charm... thanks, ByteSlinger!

bcobin’s picture

bcobin commented

Unfortunately, this only works for D5, not D6. Trying to use the same method for D6 results in a "submit."

I'd say this is more important than it would seem at first glance; anything that can confuse a user on their first visit (such as not being able to close a window they opened) is a bad thing. Any ideas? Thanks!

bcobin’s picture

bcobin commented
Version: 5.x-1.3 » 6.x-1.3
Status: Closed (won't fix) » Active

Unfortunately, this only works for D5, not D6. Trying to use the same method for D6 results in a "submit."

I'd say this is more important than it would seem at first glance; anything that can confuse a user on their first visit (such as not being able to close a window they opened) is a bad thing. Any ideas? Thanks!

hunmonk’s picture

hunmonk commented
Version: 6.x-1.3 » 7.x-1.x-dev
Category: support » feature
hunmonk’s picture

hunmonk commented

please see http://drupal.org/project/logintoboggan#commitment for more information on how task/feature requests are handled in the module

stevecowie’s picture

stevecowie commented
Status: Active » Closed (cannot reproduce)

This no longer applies afaik as this javascript behaviour doesn't apply to the block any more?

miketitsch’s picture

miketitsch commented

As far as I can tell, this is still a valid issue in the 7.x branch. However, I'm not sure the developer understood the original comment.

I believe the comment was addressing the issue of the lack of an "X" or cancel button on the javascript drop down login form. I don't see a configuration option for such a feature in the block settings. Since the developer closed this issue as "unable to reproduce), I'm not sure he understood it was a feature request instead of a bug report. Or, maybe the issue exists only with certain themes. Specifically, if someone clicks the login link out of curiousity, the drop down form appears, but there is no way to make the form go away without either logging in, using the new account link, or clicking on some other link on the web site. This is exacerbated on my site (using the Gazette theme), because sometimes the front page loads with the Login Toboggan drop down form open, even though the login link wasn't clicked.

Long story short, I believe this is a request for a cancel button on the javascript drop down form. I would make such a request myself, but chances are I would be pointed at this thread being a previous discussion.

polishyourimage’s picture

polishyourimage commented
Version: 7.x-1.x-dev » 7.x-1.3

Dear Maintainers,

I'm not sure if this feature has been included in the Dev version yet as I'm on 1.3... If it hasn't, how much would it cost me to add a CLOSE button to the "Collapsible form" in the 'User login' block?

Kind Regards,
Jase