Hi,

The "Run updates" button becomes repeated if a website has moved domain. One button points to update.php on the old domain, one to the new.

CommentFileSizeAuthor
#6 admin_menu.update.patch3.06 KBsun
#5 admin_menu.update.patch2.83 KBsun
#3 admin_menu-DRUPAL-6--1.run-updates.patch1.1 KBsun
#1 admin_menu-DRUPAL-6--1.run-updates.patch1.11 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new admin_menu-DRUPAL-6--1.run-updates.patch1.11 KB

Please test attached patch.

To test it properly, you have to press the "Wipe and rebuild" button on admin menu's settings page and access your site via different domains afterwards.

Magnity’s picture

Magnity commented
Status: Needs review » Needs work

Applied patch, and clicked "Wipe and Rebuild".

There is now no "Run updates" button on the menu.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new admin_menu-DRUPAL-6--1.run-updates.patch1.1 KB

Maybe this works then.

Magnity’s picture

Magnity commented
Status: Needs review » Needs work

W&R, still no Run Updates button.

Does it work for you?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new admin_menu.update.patch2.83 KB

Well, I thought this was easy to fix, but it turned out to be more complex.

Does attached patch work for you?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new admin_menu.update.patch3.06 KB

Last patch did not work for multilanguage sites.

Try this one instead.

Magnity’s picture

Magnity commented
Status: Needs review » Reviewed & tested by the community

Installed patch, and did W&R.
- Run updates button appears properly for user 1 and others if free access enabled.
- Logged in via different domain (without W&R or anything like that), and run updates button appears linked to the current domain correctly for users as previously.

I looked previously to see if I could do a quick patch for it and found the same issues as you had in #1 and #3 (in that because the update.php file is not within the Drupal menu system, Drupal does not display the link).

I've marked this RTBC - will leave it up to you as to whether you want any other people to test the patch too.

Thanks for your work on it.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Wow, that's a very appealing review! Can you please review and test some other patches in the queue? :)

Thanks, and thanks for replying, reviewing and testing so fast - committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

ckidow’s picture

ckidow
he/his
Primary language German
commented
Version: 6.x-1.1 » 6.x-1.2

Same problem appears here after ran last update from 6.x-1.1 to 6.x-1.2 ... thought that patch had been implemented into last release.

sorry for that... all is quite good