Translatable strings review

Thank you for these (and sorry for the delay).

I already committed part of it in http://drupal.org/cvs?commit=236322

However, I left out some parts of your patch, namely things like

-      '#description' => t('Select the default line numbering scheme: no line numbers, normal line numbers or fancy line numbers. With fancy line numbers every n<sup>th</sup> line number is highlighted. (GeSHi documentation: !link).',
-        array('!link' => l('Line numbers', 'http://qbnz.com/highlighter/geshi-doc.html#line-numbers'))),
+      '#description' => t('Select the default line numbering scheme: no line numbers, normal line numbers or fancy line numbers. With fancy line numbers every n<sup>th</sup> line number is highlighted. (GeSHi documentation: <a href="!link">Line numbers</a>).',
+        array('!link' => 'http://qbnz.com/highlighter/geshi-doc.html#line-numbers')),
     );

The usage of t(...GeSHi documentation: !link) instead of t(...GeSHi documentation: <a href="!link">Line numbers</a>) (as you suggest) is intended (aka by design): the link links to a document in English, with English section titles (e.g. 'Line numbers'). As far as I know, there are no translations available for the GeSHi documentation, so I don't think it makes sense to make the link titles translatable, when the target is in English anyway.

Another one is

-      'description' => t('%cfilter is configured to "%escape", which is likely to cause propblems with %geshifilter.',
-        array('%cfilter' => $cfilter->name, '%geshifilter' => $geshifilter->name, '%escape' => t('Escape all tags'))),
-      'solution' => l(t('Configure HTML filtering to "%strip"', array('%strip' => t('Strip disallowed tags'))), "admin/settings/filters/$format/configure", array('html' => TRUE)),
+      'description' => t('%cfilter is configured to "Escape all tags", which is likely to cause problems with %geshifilter.',
+        array('%cfilter' => $cfilter->name, '%geshifilter' => $geshifilter->name)),
+      'solution' => l(t('Configure HTML filtering to "Strip disallowed tags"'), "admin/settings/filters/$format/configure", array('html' => TRUE)),

The rationale to do t(..."%escape"...) instead of t(..."Escape all tags"...) (as you suggest) is that the string "Escape all tags" is a string from Drupal core and typically already translated. I assume that using this available translation instead of re-i18n'ing it is easier for the translator (no double work or look up necessary) and it is better for consistency.

but I could be wrong here, as I am not a large scale translator (only Dutch for some module here and there).

ok then :)
http://drupal.org/cvs?commit=236546

D5 too: http://drupal.org/cvs?commit=236552