Closed (fixed)
Project:
Spam
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Dec 2008 at 05:54 UTC
Updated:
1 Jul 2009 at 19:40 UTC
Jump to comment: Most recent file
In the 5.x-3.x version of the spam module you can configure individual spam filters by visiting "Administer >> Site configuration >> Spam >> Filters" and then selecting either "Custom", "Duplicate" or "Node age" from the submenu. In the 6.x-1.x-dev version of the Spam module, these submenus are not visible, so it is not possible to configure the "Custom", "Duplicate" or "Node age" spam filter modules.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 351247-missing-access-arguments.patch | 3.49 KB | coltrane |
| #1 | diff.patch | 3.01 KB | coreyp_1 |
Comments
Comment #1
coreyp_1 commentedThey were missing the "access arguments" declaration.
Comment #2
TBarregren commentedI've reviewed and tested the patch. It works as expected and looks correct.
Comment #3
coltranePatch in #1 doesn't apply well so here's a reroll from the base spam directory. Besides setting menu item access arguments the patch removes call to
_custom_upgrade()in theme_custom_admin_settings(). This looks correct as this function is not available though there iscustom_upgrade()in custom-upgrade.inc so I leave this for review.Comment #4
asak commentedSuccessfully applied patch in #3 - now i can configure the spam filters.
Notice: update is required for changes to take effect.
Comment #5
asak commentedSeems this doesn't solve the custom filter problem from here - http://drupal.org/node/351373.
Comment #6
gnassar commentedThis was a change in Drupal 6.2; prior to this the access arguments were inherited and this wasn't necessary.
Committed. Thank you for the patch.
Comment #7
gnassar commented