Favourite nodes title showing additonal "s"

Sagar Ramgade - December 26, 2008 - 14:29
Project:Favorite Nodes
Version:5.x-1.x-dev
Component:Code
Category:support request
Priority:normal
Assigned:Sagar Ramgade
Status:needs work
Description

Hi...I have installed the module i am facing 2 issues,
1. When i add a node to favourites in the tab it shows Favourite content_type name for guest..how do i get the username instead of guest.
2.It adds an additional "s" to the content type names which is not desirable for my requirements.

I hope you reply to my issues...thank you...

#1

who_ever - February 8, 2009 - 08:48
Status:active» needs review

Had the same issue and checked the code; there was a wrong variable used in it.

Download the ZIP-Archive and extrackt the 3 Files:
READ_ME
favorite_nodes_with_s.module
favorite_nodes_without_s.module

and rename one of the module files to favorite_nodes.module, then replace the old file in the favorite_nodes directory

who_ever

AttachmentSize
favorite_nodes.module.zip 11.76 KB

#2

kbahey - February 8, 2009 - 16:53
Version:5.x-1.3» 5.x-1.x-dev
Priority:critical» normal
Status:needs review» needs work

I agree with using the content type name, instead of the machine name. As for the "s", it is a bigger issue that we should leave out for now.

@who_ever

If you want this to be included in the base module, then please do the following:

1. Create a properly formatted unidiff patch as per the instructions here http://drupal.org/patch

2. Make sure the patch is tested

3. Make sure the patch is against the 5.x-1.x-dev tarball.

You will be credited in the commit message.

#3

who_ever - February 8, 2009 - 18:17

@ kbahey

Thanks for your advice, I'll apply the patch as soon as I've read the documentation about patches.

#4

kbahey - February 8, 2009 - 18:20
Title:Issue with the module» Use content type name, not machine name

Changing the title to describe better what this is about.

#5

Sagar Ramgade - February 14, 2009 - 06:39
Title:Use content type name, not machine name» Favourite nodes title showing additonal "s"
 
 

Drupal is a registered trademark of Dries Buytaert.