In admin/node, "Delete the selected posts" does not work

Also see: http://drupal.org/node/37695

I think (though I'm not sure) that part of the problem was the dispatch done by node_admin(). Either way it was an un-needed layer of redirection.

The main problem was that node_admin_nodes() was mixing up the two forms just to get the values set in the $form_values global. All the needed data was in the $_POST so I now the delete form is independent of the node_admin_nodes() form. I renamed node_multiple_delete_form() to node_multiple_delete_confirm() to match the name of the the single node delete function (node_delete_confirm()).

Give the attached patch a try. There may be a cleaner way to do it but, I've done a bit of testing on it and this seems to work pretty well.

Applied and mass deleting worked. Good code improvement too.
+1

Patch works, +1 on the cleanup too.

The only part I don't like is where you added the code for title-less nodes. As far as I know, all nodes require a title. There are plenty of UI parts which would otherwise be empty or broken. Plus, you used a non-localizable string, with non-semantic italic tags (we would use em instead).

Committed to HEAD minus that 'untitled' part.

Ahh, sorry about that title-less nodes bit. I'd ment to filter that out before rolling the patch. The whole reason I found the bug (and needed to fix it) was to clean up a bunch of title-less nodes left over from a broken module. I'd add the titles as part of the debugging process.