When there isn't a vocabulary coupled to the 'forum topic' $node->type, there automaticcally is being made a vocabulary 'Forums'. this is all going very well, accept the fact that the satus message isn't returned..

It's good to know hen drupal does things automaticcally...

CommentFileSizeAuthor
#13 tax-watchdogs.patch2.76 KBZen
#12 log_taxonomy_changes_1.patch2.67 KBprofix898
#10 log_taxonomy_changes_0.patch2.67 KBprofix898
#6 log_taxonomy_changes.patch2.38 KBprofix898

Comments

profix898’s picture

profix898 commented

Maybe add watchdog message when creating vocabulary.

forum.module (line 315):
watchdog('forum', t('vocabulary \'Forums\' automatically created'), WATCHDOG_NOTICE);
Zen’s picture

Zen commented
Assigned: Unassigned » Zen
Priority: Critical » Minor

Marking as minor.

Thanks
-K

Zen’s picture

Zen commented
Assigned: Zen » Unassigned
magico’s picture

magico commented
Category: bug » feature
Priority: Minor » Normal
Zen’s picture

Zen commented
Title: $status is not returned when the vocabulary 'Forums' is being made » taxonomy module does not log anything
Component: forum.module » taxonomy.module
Category: feature » task

I believe this is more of a taxonomy module issue - it does not have a single watchdog call. Fixing it should fix the forum module issue as well.

This is an administration usability issue.

-K

profix898’s picture

profix898 commented
Status: Active » Needs review
StatusFileSize
new log_taxonomy_changes.patch2.38 KB

This very simple patch logs (create/update/delete term/vocab) changes in taxonomy to the watchdog.

Zen’s picture

Zen commented
Status: Needs review » Needs work

Hi,

I think that the vocabulary and term names need to be wrapped in a theme_placeholder call. Looks good otherwise.

-K

profix898’s picture

profix898 commented
Status: Needs work » Needs review

1. What's different in passing the string to drupal_set_message() from passing it to watchdog()?
2. %var is using placeholder, not? (! = insert directly, @ = check_plain, % = check_plain+placeholder)

Zen’s picture

Zen commented

You're quite right - that is the case for HEAD; something I was unaware of.

I'll let somebody else with a checkout of HEAD review this.

Cheers,
-K

profix898’s picture

profix898 commented
StatusFileSize
new log_taxonomy_changes_0.patch2.67 KB

Added a 'edit' link to watchdog to go directly to created/modified vocabulary/term.

drumm’s picture

drumm
he/him
Location NY, US
commented
Version: x.y.z » 6.x-dev
Status: Needs review » Needs work

patching file modules/taxonomy/taxonomy.module
Hunk #1 FAILED at 277.
Hunk #2 succeeded at 373 (offset 21 lines).
Hunk #3 succeeded at 455 (offset 36 lines).
Hunk #4 succeeded at 596 (offset 51 lines).
1 out of 4 hunks FAILED -- saving rejects to file modules/taxonomy/taxonomy.module.rej

profix898’s picture

profix898 commented
Status: Needs work » Needs review
StatusFileSize
new log_taxonomy_changes_1.patch2.67 KB

... Patch rerolled ...

Zen’s picture

Zen commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new tax-watchdogs.patch2.76 KB

Patch still applies. Minor change: "Term %term has been updated" ought to be "Updated term %term" for consistency with all the other messages in the module. Updated and setting to RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

drumm’s picture

drumm
he/him
Location NY, US
commented

Committed to 5.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)