taxonomy module does not log anything

Maybe add watchdog message when creating vocabulary.

forum.module (line 315):
watchdog('forum', t('vocabulary \'Forums\' automatically created'), WATCHDOG_NOTICE);

Marking as minor.

Thanks
-K

I believe this is more of a taxonomy module issue - it does not have a single watchdog call. Fixing it should fix the forum module issue as well.

This is an administration usability issue.

-K

This very simple patch logs (create/update/delete term/vocab) changes in taxonomy to the watchdog.

Hi,

I think that the vocabulary and term names need to be wrapped in a theme_placeholder call. Looks good otherwise.

-K

1. What's different in passing the string to drupal_set_message() from passing it to watchdog()?
2. %var is using placeholder, not? (! = insert directly, @ = check_plain, % = check_plain+placeholder)

You're quite right - that is the case for HEAD; something I was unaware of.

I'll let somebody else with a checkout of HEAD review this.

Cheers,
-K

Added a 'edit' link to watchdog to go directly to created/modified vocabulary/term.

patching file modules/taxonomy/taxonomy.module
Hunk #1 FAILED at 277.
Hunk #2 succeeded at 373 (offset 21 lines).
Hunk #3 succeeded at 455 (offset 36 lines).
Hunk #4 succeeded at 596 (offset 51 lines).
1 out of 4 hunks FAILED -- saving rejects to file modules/taxonomy/taxonomy.module.rej

... Patch rerolled ...

Patch still applies. Minor change: "Term %term has been updated" ought to be "Updated term %term" for consistency with all the other messages in the module. Updated and setting to RTBC.

Committed to CVS HEAD. Thanks.

Committed to 5.