I'm right now coding a theme with light text on dark background and I'm bumping into problems with CSS-files that hasn't taken this into consideration.

When assigning a light background color you can't assume that the front color will be light as well - a dark front color should be assigned at the same time.

I'm attaching a patch for this.

CommentFileSizeAuthor
coder_front_color.patch492 bytesvoxpelli

Comments

dvessel’s picture

dvessel commented

As long as the elements which use the .coder-* classes do not mix with core’s .notice, .warning and .error, I think this is a sensible thing to include. Sorry, I didn’t check.

Both should be set usually. The only time it one side can be omitted safely is when the set colors are considered as a whole and you know how the colors cascade and interact.

So +1

douggreen’s picture

douggreen commented
Status: Needs review » Closed (fixed)

committed to the 7.x-2.x branch, thanks!