Remove redundant code from forum.module
Stefan Nagtegaal - October 25, 2005 - 14:52
| Project: | Drupal |
| Version: | x.y.z |
| Component: | forum.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Stefan Nagtegaal |
| Status: | closed |
Jump to:
Description
forum.module uses _forum_depth(), which is depricated. The same function is present in the taxonomy.module, and does exactly the same thing.. Here it's called, _taxonomy_depth()..
Attached small patch removes the function _forum_depth() and all it's references..
Please review and apply...
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| forum-module_1.patch | 1.88 KB | Ignored | None | None |
#1
+1
Forums already require taxonomy.module, so no new dependancy is added, code is simplified.
#2
i read through this simple patch and it is ready for commit.
#3
Committed to HEAD. Good catch.
#4