Remove include_once('skeleton_common.inc');

agentrickard - December 29, 2008 - 21:59
Project:Skeleton outlines
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

The include line (line 12) is not necessary, since the common file is loaded by all the subfiles. This include structure predates the D6 menu system and should be removed.

#1

agentrickard - December 29, 2008 - 22:11
Status:active» needs review

To make this work, we need to move the two menu loader functions from the common file to the module file, which is more in keeping with D6.

AttachmentSize
skeleton_include.patch 2.95 KB

#2

deviantintegral - January 7, 2009 - 01:45
Status:needs review» fixed

Thanks - that was something I was meaning to do but hadn't done yet. It makes the code much cleaner.

#3

System Message - January 21, 2009 - 01:50
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.