Download & Extend
Issues

Forms API: Select labels have wrong 'for'

Posted by m3avrck on October 25, 2005 at 7:17pm
Project:Drupal core
Version:x.y.z
Component:base system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Labels generated for SELECT boxes are incorrect. For example, on admin > settings :

<label for="edit[error_level]">Error reporting:</label><br />
<select name="edit[error_level]" id="edit-error_level">

Those [ should be - .

Login or register to post comments

Comments

#1

Posted by tangent on October 25, 2005 at 8:47pm

I do not see a #for attribute specified in the Forms API docs, nor in the code. I suspect this is a bug with the module creating the form. Can you describe a reproducible scenario for this bug?

#2

Posted by m3avrck on October 25, 2005 at 8:51pm

tangent, check out the latest HEAD, it is wrong in admin > settings, along with wrong in my custom module. It it how the API creates the ... it generates the ID wrong from the form element.

#3

Posted by m3avrck on October 25, 2005 at 8:53pm

oops that should have been:

<label for='[myformid]'>
<input type="text" id="my-form-id" />

This doesn't correctly transcribe the form id into the matching label for field. Nothing in a module touches this, it is completely up to the Forms API.

#4

Posted by chx on October 25, 2005 at 9:23pm
Status:active» fixed

I fixed in Bryght SVN. Expect the form.inc patch soon.

#5

Posted by Anonymous on November 8, 2005 at 9:40pm
Status:fixed» closed (fixed)