Replace generic javascript error message with something more useful

Sutharsan - December 30, 2008 - 12:12
Project:Session Favorites
Version:5.x-1.3
Component:User interface
Category:feature request
Priority:normal
Assigned:Unassigned
Status:active
Description

When a visitor click the same add to / remove from favorites link twice a 'booz' message (JS alert) is shown. This should be replaced by a more meaning full message like 'You already added this to your favorites'.

I mark this as bug because the message is totally useless to the user.

#1

jhedstrom - December 30, 2008 - 17:24
Status:active» fixed

Thanks Sutharsan. I really can't believe I left that in there...it was a placeholder error message. I've replaced it with a generic 'an error has occurred' message. If you can provide more information on how this error message is being displayed (I can't seem to get the code to fail in such a way that it is exposed), I may be able to add a more useful message.

#2

Sutharsan - December 30, 2008 - 19:42
Status:fixed» needs work

The simplest way to reproduce the error is opening the same node in two different browser windows/tabs. Add it to the favorites and repeat it in the other window. The same procedure for the removal. The best response i.m.o. is to have the normal front-end response (change link text & feedback message) but without backend addition/removal.

#3

jhedstrom - December 30, 2008 - 20:19
Title:replace booz message» Replace generic javascript error message with something more useful
Category:bug report» feature request
Status:needs work» active

Changing status since the original issue has been patched and fixed.

 
 

Drupal is a registered trademark of Dries Buytaert.