Closed (fixed)
Project:
Webform
Version:
5.x-2.3
Component:
Translation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Dec 2008 at 12:35 UTC
Updated:
10 Nov 2009 at 09:04 UTC
Here's Czech localization of Webform that corresponds to updated PO template generated for version 5.x-2.3. Both files are attached.
I noticed that names for form components (textarea, grid,...) are not included in the template while some other redundant strings are. Is there a reason for this? If the default drupal localization lacks translation of these strings, localized Webform won't fix it even if it's part of the module...
Comments
Comment #1
quicksketchThanks! I've added both files. The last several .pot files were generated by GoofyX (which I'm very thankful for). You might ask him about irregularities in those files. I'm still rather ignorant of any usage of locale beyond theory.
Comment #2
GoofyX commentedHi,
Sorry for "poluting" the issue queue quicksketch. charmer contacted me using the contact form here in drupal.org and I thought I should reply using this issue.
Whatever templates I committed were created using the latest version of potx, so if there are missing strings, then it's potx's fault. Which strings are missing from the templates? charmer, could you give more specific examples?
Comment #3
charmer commentedThat's a slight misunderstanding - I too use potx for generating templates and it always worked just fine for me.
As I stated above I miss strings for individual component types i.e. strings like "textarea", "grid", "markup", "fieldset" and others. But I believe they are not part of the template because they are not marked as strings for localization in source files like in this example:
t("Options").I couldn't even find the labels to mark them myself and I thought GoofyX may be able to help in this. I've found that each component type has its .inc file in components directory of the module. I think that adding label for each type and marking it as localizable string would be enough but I'm not sure where exactly to put these labels and not break anything.
The point is that since Webform uses these form types extensively it should have them localizable so the user wouldn't have to depend on main drupal PO template to have them.
Comment #4
GoofyX commentedOK, now I understand what you mean.
It's up to quicksketch to provide a maybe string array of the component types, wrapping the strings in t() calls, so that potx will catch them.
quicksketch, what do you think?
Comment #5
quicksketchOr better, yet, we really need to simply ask each component .inc file what it's proper name is directly, rather than assuming it's the same as .inc file. Especially since some components like "pagebreak" should really be two words: "Page break".
Comment #6
charmer commentedYes, I think that's exactly it! Thank you in advance.
Comment #8
charmer commented