On the settings page of the freelinking module, one can restrict free links to choosen content types. The variable is stored as an array. Finaly the _freelinking_exists() function gets the variable and is supposed to build the query to search for the right node to link to. However, the 'where' clausule is not added to the query. Here comes the fix.

  $noderestrict = variable_get('freelinking_restriction', NULL);
  if (isset($noderestrict) && $noderestrict['none'] =! 'none') { // need to add the where clause

Fix:

  $noderestrict = variable_get('freelinking_restriction', array('none'));
  if (is_array($noderestrict) && !in_array('none', $noderestrict)) { // need to add the where clause
CommentFileSizeAuthor
#1 freelinking-restriction.patch1.04 KBtoemaz

Comments

toemaz’s picture

toemaz commented
Status: Active » Needs review
StatusFileSize
new freelinking-restriction.patch1.04 KB

Find the patch attached. The patch is running in production on http://musescore.org/en/handbook

Kripsy’s picture

Kripsy commented

I can confirm this fixes the problem.

toemaz’s picture

toemaz commented
Status: Needs review » Reviewed & tested by the community

Thx for kicking in. What I find rather strange is that no one else has this problem. Or nobody cares about the problem.

Kripsy’s picture

Kripsy commented

Well, it relies on content across different node types having the same title and then being hyper linked and even then would depend on the node type weight for someone to notice. I just don't think most people run into this case a lot but on a wiki style site that also has media and forum topics like mine it happens A LOT so I noticed pretty quickly. :)

toemaz’s picture

toemaz commented

@Krispy
Add to this that my setup is multilingual as well and the stress test for the freelinking module is complete. I have one other outstanding but solved freelinking issue which waiting to be committed for almost half a year. Hopefully this one can be committed a bit faster.

toemaz’s picture

toemaz commented
Status: Reviewed & tested by the community » Fixed

Patch has been applied to 6.x-1.x as well as 6.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.