Hi Michelle et al -

I have a semi-AVF related question (but it's mostly a core Forum question I don't know where to ask elsewhere and get the same quality response).

Anyhow - I'm working on my 2nd drupal site (first in 6.8, the other in 6.6), and for whatever reason the Forum module in my 6.8 site is acting more like a post with its own comments section (where users can't reply to the post and instead have to add a new comment), instead of a single forum thread. This isn't occuring in my 6.6 site, and I can't find a setting anywhere that controls how this is handled - the forum content is setup exactly the same in both my sites.

Attached are screenshots comparing the 2 forums. Once I get this little issue fixed I plan on installing the authorpane/AVF dev tarballs to help the live testing...

Thanks!

CommentFileSizeAuthor
GoodForum.png40.45 KBApollo610
badForum.png160.21 KBApollo610

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Active » Postponed (maintainer needs more info)

Just to clarify, does this problem happen when you have AF turned off? Are you using the theme settings api module? The other issues where the reply button disappeared it was due to conflicts with that.

Michelle

Apollo610’s picture

Apollo610 commented

Thanks for the quick reply Michelle.

Yeah it happens with AF turned off, so it seems to definitely be something with the core forum mod. I'm not using the Theme Settings API mod...

Actually, I just switched the theme to Garland (I was using Painted Wall), and the forum looks as it should (minus the reply and quote buttons in the original post, which are missing - it's in all subsequent posts but I should be able theme those). I never thought it would be a theme-related issue...

So it seems like the Painted Wall theme is treating replies to forum posts as "Comments" and seperating them into their own section, per the usual behavior for other content types. Have you seen this before? I'll have to dive into the theme to see what's going on, perhaps bring it up with the theme developers just to let them know...

Thanks again -

Apollo610’s picture

Apollo610 commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

Ok was able to figure out the issue - it was indeed with the theme, it added an additional function that formatted the forum to include a comments area.

Still need to track down what's going on with the missing reply/quote buttons on the initial forum post, but I'll close this out since it isn't an issue with AVF/Forum but most likely something with the theme.

Thanks -

Just an FYI, this is for the Painted Wall theme:
In phptemplate_comment_wrapper() I just had to tweak the forum format code that was adding the comments block.

From: return '<div id="comments"><h2 class="comments">'. t('Comments') .'</h2>'. $content .'</div>';
To: return '<div id="comments">' . $content . '</div>';

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Title: Strange Forum Behaviour » Update to D6 theme system
Project: Advanced Forum » Painted Wall
Version: 6.x-1.0-alpha16 » 6.x-1.x-dev
Category: support » bug
Status: Closed (fixed) » Active

If Painted Wall is using phptemplate_comment_wrapper() in D6, then that is a bug and will cause more problems than just an extra word. The theme system has changed in D6. While it's technically possible to use the old style theme overrides, that should only be done a particular site and not in a contrib theme. See #295895: Garland overrides overrides template with theme function for the issue filed against Garland for the same reason.

Michelle

Apollo610’s picture

Apollo610 commented

Thanks Michelle, I forwarded your message along to the theme developer who's been very responsive thus far.

I know it doesn't make much difference since there's a fundamental issue using old theme functions, but the issue I had stumbled across earlier today was actually related to the conditional statement in that function not firing... I made a slight tweak and all is well so far. Luckily I've had no other problems to date with the theme or any of the contrib's hooked into it.

Anonymous’s picture

Anonymous (not verified) commented

Yep, I'll have to look more into this function, and make it more d6 friendly. At least I'm happy that you can work with it. I'll post the modification I submit to this theme in this thread so you're aware of what I change.
Thanks for this !

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

@Apollo610 - In a nutshell, using the old D5 style overrides short circuits the new preprocess system and makes it so my preprocessing of the comment wrapper in AF doesn't happen. Right now, the only thing this affects is the reply button at the bottom, but there may be more in the future.

@couzinhub - Thanks for looking into it. Unfortunately, when Garland has a bug it tends to spread as other themes follow what Garland does. :(

Michelle

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Status: Active » Needs work

@Michelle | yeah thanks for pointing that out, I used this function since such a longtime that I'm not even able to remember where I got it, and it might be Garland indeed :)
That'll give me the opportunity to review the template.php code.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Fixed

Just commited the update on the dev version

Anonymous’s picture

Anonymous (not verified) commented

( I reviewed the template.php, and added the comment-wrapper.tpl.php )

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.