Hi Couz, great work with this theme. It's beautiful and very easy to use.

I have a quick question regarding its handling of core forums. When Painted Wall is enabled on my test site, it seems to treat forums as regular content, where the inital post topic is the "page" and all subsequent replies are "comments" and put in their own area below the original post. The usual forum format is to have a single thread based on the first post. I switch my site over to Garland theme just to confirm and it works there.

Attached are 2 screenshots of the same forum posts with these 2 themes.

Is there a way to modify this in Painted? I would like to continue using this theme as I love it and have themed the rest of my site around it - forums was the last piece and the only thing giving me fits at this point.

Thanks!

CommentFileSizeAuthor
painted_forum.png129.27 KBApollo610
garland_forum.png22.83 KBApollo610

Comments

Anonymous’s picture

Assigned: Unassigned »

It looks like you are not using the core forum, but the advanced forum module. I never tested the advanced forum module on it, so am not so surprised that there is some display bugs.

If I understand, one of your concern is that big 'Comment' title that you see on the screenshot #2. Advanced forum still uses the drupal standard (first post is the page), but just theme the comments so it looks exactly the same. So basically, you just have to remove that title for forum posts. This title is made through a theme function that you can finf in the template.php file. Find it, delete it or just remove the title in it, and it shold be good.

Then, you just have to tweak some css rules so they don't apply to the advanced forum comments.

Apollo610’s picture

Status: Active » Closed (fixed)

Ahhh, thank you sir for pointing me in the right direction. In phptemplate_comment_wrapper() I just had to tweak the forum format code that was adding the comments block.

From: return '<div id="comments"><h2 class="comments">'. t('Comments') .'</h2>'. $content .'</div>';
To: return '<div id="comments">' . $content . '</div>';

Just an FYI, the theme works perfectly with AVF... I was having the issue with AVF disabled as well but didn't check template.php for the forum code.

Thanks for your help -

Anonymous’s picture

Awesome. Feel free to ask !

You made me realized that I should definitely document the theme a little bit more... I made it using Basic, and as I also have to make some documentation for it... I'll do Basic first and then Painted.

Apollo610’s picture

Status: Closed (fixed) » Needs review

Documentation never hurts, but thankfully this theme's fairly straightforward. :)

I was playing around with this a bit more and noticed why I was having problems earlier... it seems the condition statement wasn't firing in that function, so every comment area was falling into the "else" bucket...

Quick, minor fix:

Old code

 function phptemplate_comment_wrapper($content, $type = null) {
  static $node_type;
  if (isset($type)) $node_type = $type;

  if (!$content || $node_type == 'forum') {
...
...
}

New code

 function phptemplate_comment_wrapper($content, $type = null) {
  static $node_type;
  if (isset($type)) $node_type = $type;

  if (!$content || $node_type -> type == 'forum') {
...
...
}

Relatively minor, but that removes the "Comments" subsection that was being inadvertantly created in the forums but keeps it for every other content type.

Thanks again!

Anonymous’s picture

Nice one, I'll test and submit

Anonymous’s picture

Commited to dev

Anonymous’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.