When this module is used with user mailman register, the increased number of columns in the table causes the table to grow very wide. Another problem with this is that user_mailman_register introduces the description which is a very long text field which when presented in a narrow column causes the row height to become very large, making the whole table look ugly. This can be fixed by explicitly selecting the required fields - lid, name and command.

CommentFileSizeAuthor
#1 mailman_manager_fix_wide_columns_352598_2.patch.gz699 bytesanoopjohn

Comments

anoopjohn’s picture

anoopjohn commented
Title: Fixing wide table with too many columns when used with user_mailma_register » Fixing wide table with too many columns when used with user_mailman_register
Status: Active » Needs review
StatusFileSize
new mailman_manager_fix_wide_columns_352598_2.patch.gz699 bytes

I am attaching a patch for this issue, please review and use

anoopjohn’s picture

anoopjohn commented

The table also lacked the empty header declarations and I missed to add it.
Please add
at line 397

                   array('data' => NULL),
                   array('data' => NULL),

so that the header declaration in function _mailman_manager_admin_display() becomes

  $headers = array(array('data' => t('ID'), 'field' => 'lid', 'sort' => 'asc'), 
                   array('data' => t('Name'), 'field' => 'name'),
                   array('data' => t('Request Address'), 'field' => 'command'),
                   array('data' => NULL),
                   array('data' => NULL),
                   );

If the empty headers are not present and when there are more than one row in the table and when you scroll the page floating headers will not get correctly aligned to the columns.

samuelet’s picture

samuelet commented
Version: 6.x-2.1 » 6.x-1.x-dev
Status: Needs review » Fixed

In late, but finally commited ;-)
Thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.