RSS feed not working - not valid RSS feed error
Anonymous (not verified) - December 30, 2008 - 21:26
| Project: | Recent Changes |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Description
Trying to add the recent changes RSS feed to an RSS reader comes up with the error: This is not a valid RSS feed.
Tried with Thunderbird and Google Reader. Have used the 5.x version of Recent Changes with Thunderbird as the RSS reader for years without issue.
#1
Is this module being maintained?
The RSS feed is half of the functionality.
#2
On line 296
<?php$url = call_user_func_array('url', array_merge($item->url_array, array(TRUE)));
?>
has to be changed into
<?php$item->url_array[1]['absolute'] = TRUE;
$url = call_user_func_array('url', $item->url_array);
?>
#3
Find it attached. I deployed it on a production website. Lets see how it works out.
#4
Thanks for the work on the patch toemaz.
I applied the patch using the normal patch command. Still getting the same error.
Also tried manually editing the file as described in #2. No luck there either.
Any suggestions of what I could be doing wrong?
#5
Did you empty the cache?
Go to: admin/settings/performance
Second, perhaps your RSS reader has a cache layer as well?
#6
Thanks for the suggestions. It turned out to be just a permissions issue. I hadn't set the new access recent changes permission in 6.x yet. Setting that made the feed work for both the dev version, and the patch you submitted.
So both work. What does your patch do exactly? If it's presenting the feed in a better / more correct way, it could still be worth committing.
#7
Strange. The dev version didn't work out for me. Well, I guess more people will hit the bug if it's really out there. Lets wait and see.
#8
I had the same problem, applied #2, which solved it.
#9
A similar error occurs with
theme('username'...calls in this module.theme_usernameyields only relative paths, not absolute paths that are needed for RSS feeds. I am looking for a solution.#10
Hm, seems #9 shouldn't be a problem, since
xml:baseis correctly outputted in the feed. Still I feel that theming shouldn't be applied to RSS output. Therefore I propose the following change in line 475:$result_title_add .= (!$is_comment && ($result->uid != $result->auid)) ? $owner_intro_text . theme('username', $owner_user) : '';$result_title_add .= ($is_comment) ? t('on') . ' ' . l($result->title, "node/$result->nid") . ' ' . t('from') . ' ' . theme('username', $owner_user) : '';
into
$result_title_add .= (!$is_comment && ($result->uid != $result->auid)) ? $owner_intro_text . $owner_user->name : '';$result_title_add .= ($is_comment) ? t('on') . ' ' . l($result->title, "node/$result->nid") . ' ' . t('from') . ' ' . $owner_user->name : '';
#11
Better creating a new issue for this. Since you tested to patch from #3, I consider it tested by the community.