Download & Extend

Wrong use of func_get_args()

Project:Kaltura
Version:6.x-1.3
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

func_get_args() returns an array containing all the arguments passed to a function, including the ones declared in its parameters list.
A line like if ($args[0] == 'type') $type = $args[1]; (present in kaltura_preview_player()) is simply getting back the same value given to $no_js.

If the function is being called with two different types of parameters, then it would be better to use an empty parameters list, and use just the values given by func_get_args().

Comments

#1

fixed in 6.x-1.4 and 5.x-1.3, function removed since it was never even used

#2

Status:active» fixed

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here