Hey guys,

I've been keeping up the cache serialization patches in Cache Router, just thought I would share the love. Here is 5.0 - 5.14 that all apply cleanly. I would just commit it myself, but I figured better to keep you in the loop and open an issue.

Let me know if you want me to commit it.

Steve

CommentFileSizeAuthor
#2 memcache-5.x-1.10.patch3.63 KBrobertdouglass
patches.zip30.98 KBslantview

Comments

hound’s picture

hound commented

Just wondering - when I enable memcached and apply your patch to 5.14, I have a whitescreen issue, which displays this error if I turn on verbose PHP:

Fatal error: require_once() [function.require]: Failed opening required  (include_path='.:/usr/local/share/pear') in /blah/blah/blah on line 890

on a box that is running Suhosin-hardened Apache and also Suhosin-hardened PHP5 (as installed from the Ubuntu 8.04 repos.) It occurs to me that maybe memcached does not play nicely with Suhosin.

See this other thread for more details.

Any comments or hints are welcome. This is driving me bats.

robertdouglass’s picture

robertdouglass commented
StatusFileSize
new memcache-5.x-1.10.patch3.63 KB

A patch I received via email.

svenb’s picture

svenb commented

Some notes to the "memcache-5.x-1.10.patch" above...

After installing the 5.x-1.10 it seems like all objects stored with CACHE_PERMANENT (expire = 0) were always evaluated as expired. So I fixed the condition in line 75 of "dmemcache.inc" to handle that correctly. I noticed a similar behavior for the CACHE_TEMPORARY (expire = -1), which leads me to move a few lines of code in "memcache.inc" and "memcache.db.inc". Now the "-1" gets replaced by the configured cache lifetime.

While analyzing the issues I turned on the memcache statistics and it didn't show the headlines (Get, Set, Hit, ...). Quick fix in line 245 of "memcache_admin.module" should fix that.

Hope that helps.

plan9’s picture

plan9 commented

Thanks for the above patch. Without it I was unable to configure blocks settings for multiple themes. I seemed to be getting stale data - with the block preview for each theme being stuck on the default theme. I also had a few other glitches with memcache API installed - mostly seemingly to do with admin operations being cached.

plan9’s picture

plan9 commented

I've just noticed that my PECL memcache library 2.1.2 was below the recommended version stated in the 5.x install read me text: 2.2.1. I used the install procedure documented here: http://www.lullabot.com/articles/how-install-memcache-debian-etch which links to version 2.1.2

Although the patch seemed to fix my issues - the out of date PECL could explain the glitchy behaviour I described above.

plan9’s picture

plan9 commented

Actually - after updating PECL memcache library the behaviour I mentioned previously: not being unable to configure blocks settings for multiple themes persists.

The patch seems to fix it.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Closed (won't fix)

Marking 5.x issues won't fix since that branch is no longer supported.