"My recent posts" like in Drupal

Views comes with a "tracker" view that replicates this functionality. Why not clone that as a starting point for your view?

Michelle

Apparently I never wrote an argument to work properly for the tracker view. How surprising.

FYI: This will be necessary for the full views2 port of project_issue: #359129: Convert the "My issues" page to a view...

Actually I was wrong. I did write the argument, I just put the wrong one in the default.

I've modified the default tracker view in -dev. If you've overwritten your tracker view or just want to fix yours, change the argument to "Node: User posted or commented" (You'll have to delete the existing one and add a new one with the same options).

It'd be nice to have this as an filter, too (e.g. for the "Participant" exposed filter for the issue queue advanced search, http://drupal.org/project/issues/search/views).

Having this as an exposed filter would help the d.o upgrade -- tagging as such.

This seems to do it. Not sure if its the right way though.

+    $args = array_values($this->value);
+    // @todo this could probably be done more efficiently.
+    foreach ($args as $value) {
+      $args[] = $value;
+    }

This looks like 2 routines that do the same thing (and the first one is faster). Is the loop doing something else I'm missing?

It's adding the placeholder values again, since $condition is used twice.

I'm not sure why this isn't using db_placeholders()...

This was mostly working fine, but I re-rolled it for a few things:

A) This is a lot more clear about what's going on:

+    // We include the WHERE condition twice in the query, so we need two
+    // copies of these argument values.
+    $args = array_values($this->value);
+    $args = array_merge($args, $args);

B) "Display comments only if a user posted the node or commented on the node" is misleading. This is matching nodes, not comments.

Otherwise, this is exactly what I need for the "Participant" exposed filter on the advanced issue search.

Committed!