Here's an updated patch for Drupal 5.14 for testing.

I uploaded it two ways:

DRUPAL-5.14.patch is the patch file that goes into the module's directory.

coresearches-drupal-5.14.patch is the proper patch against the module to create the patch.

CommentFileSizeAuthor
#8 DRUPAL-5.20.patch20.04 KBdamien_vancouver
#4 DRUPAL-5.15.patch20.09 KBdamien_vancouver
DRUPAL-5-14.patch20.09 KBdamien_vancouver
coresearches-drupal-5.14.patch20.95 KBdamien_vancouver

Comments

damien_vancouver’s picture

damien_vancouver commented
Title: Drupal 5.14 patch » Drupal 5 - latest updated patch

Here's the DRUPAL-5.15 patch.

damien_vancouver’s picture

damien_vancouver commented

hm trying again, attachments not working right.

damien_vancouver’s picture

damien_vancouver commented

one last time, or i'll try later when it is working...

damien_vancouver’s picture

damien_vancouver commented
StatusFileSize
new DRUPAL-5.15.patch20.09 KB

DRUPAL-5.15 patch

jonathan_hunt’s picture

jonathan_hunt commented

FYI, the patch in #4 works for me on Drupal 5.18

damien_vancouver’s picture

damien_vancouver commented
Status: Needs review » Reviewed & tested by the community

Yep it worked unmodified for me in 5.18 as well. Thus I'm marking reviewed & tested by the community.

Should this get committed [ :) ] then I think the patch should be more generically named inside the module instead of by version like it is now.

i.e. remove modules/coreseraches/DRUPAL-5*.patch and replace with this one as

modules/coresearches/DRUPAL-5.patch

would do that job nicely and it would probably keep working for rest of time (or we can update it as needed). There have been no changes requiring a new patch in quite a while and Drupal 5.x is probably not going to change much from here.

I'll continue to update the patch on this issue though, but only bump the thread if there are changes and the patch no longer works with the latest version. Anyone having trouble can feel free to post here and I should see it and help!

agileware’s picture

agileware commented

Works for 5.19 too.

damien_vancouver’s picture

damien_vancouver commented
StatusFileSize
new DRUPAL-5.20.patch20.04 KB

Hi all, here is a working patch for DRUPAL 5.20 (and perhaps beyond!).

Please let me know if anyone runs into problems, and also please report success or failure here as you try and use it for new versions.

damien_vancouver’s picture

damien_vancouver commented
Status: Reviewed & tested by the community » Needs review