Posted by damien_vancouver on December 31, 2008 at 8:28pm
| Project: | Core searches |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | damien_vancouver |
| Status: | needs review |
Issue Summary
Here's an updated patch for Drupal 5.14 for testing.
I uploaded it two ways:
DRUPAL-5.14.patch is the patch file that goes into the module's directory.
coresearches-drupal-5.14.patch is the proper patch against the module to create the patch.
| Attachment | Size |
|---|---|
| coresearches-drupal-5.14.patch | 20.95 KB |
| DRUPAL-5-14.patch | 20.09 KB |
Comments
#1
Here's the DRUPAL-5.15 patch.
#2
hm trying again, attachments not working right.
#3
one last time, or i'll try later when it is working...
#4
DRUPAL-5.15 patch
#5
FYI, the patch in #4 works for me on Drupal 5.18
#6
Yep it worked unmodified for me in 5.18 as well. Thus I'm marking reviewed & tested by the community.
Should this get committed [ :) ] then I think the patch should be more generically named inside the module instead of by version like it is now.
i.e. remove modules/coreseraches/DRUPAL-5*.patch and replace with this one as
modules/coresearches/DRUPAL-5.patch
would do that job nicely and it would probably keep working for rest of time (or we can update it as needed). There have been no changes requiring a new patch in quite a while and Drupal 5.x is probably not going to change much from here.
I'll continue to update the patch on this issue though, but only bump the thread if there are changes and the patch no longer works with the latest version. Anyone having trouble can feel free to post here and I should see it and help!
#7
Works for 5.19 too.
#8
Hi all, here is a working patch for DRUPAL 5.20 (and perhaps beyond!).
Please let me know if anyone runs into problems, and also please report success or failure here as you try and use it for new versions.
#9