Could you integrate a free field for the 'more'-link? e.g. I would like to have Feature-Archive, or News-Archive instead of more

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

agentrickard’s picture

Status: Active » Needs review
FileSize
4.86 KB

Like this?

agentrickard’s picture

FileSize
4.65 KB

Patch accidentally included some extra code.

merlinofchaos’s picture

Wow, nice job, Ken.

Only one problem, I think: The definition for the option could include 'translatable' => TRUE and the default should then not be run through t().

agentrickard’s picture

Also makes sense.

Do you see any need to run argument replacement patterns here? (Which is something I thought about doing.)

merlinofchaos’s picture

That would allow us to get titles into the links, though because they're arguments they won't change per record so it'll be a lot of repeating data. If we do the current system you have set up will clash (%1 currently gets the argument whereas in substitution data %1 would get you the title for argument 1) -- it may be something we should make possible by removing that collison but not actually implement unless we can come up with a use case.

agentrickard’s picture

FileSize
4.87 KB

OK. Baby steps. This patch just allows the changing of the text. No argument substitutions.

erikhopp’s picture

Version: 6.x-2.2 » 6.x-2.5
Status: Needs review » Reviewed & tested by the community

I just tested this patch vs. 6.x-2.5 and it works! (It says that one hunk failed, but it was just a new line issue at the end of the views module.)

This would be a great improvement. Waiting for argument support shouldn't hold this patch up in my opinion.

Erik.

merlinofchaos’s picture

Status: Reviewed & tested by the community » Fixed

Committed! Thanks!

frankcarey’s picture

to clarify, would this be a more link for truncated fields?

agentrickard’s picture

No. It make the 'more' link on a block view configurable.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Colorful Tones’s picture

Category: feature » bug
Status: Closed (fixed) » Needs review
FileSize
2.24 KB
10.04 KB

I just updated to 6.x-2.5 from previous 6.x and now my 'more' links are not displaying. I thought it had something to do with my custom template file for that View, because I had moved the 'print $more' call further up in the template in order to try and get it closer to my teaser. However, after removing my custom template file it did not solve. I confused as to whether this thread was related or not? What was this thread solving? Any suggestions?

merlinofchaos’s picture

Status: Needs review » Active

'needs review' means there is a patch attached. Moving to the proper active status.

rfay’s picture

Status: Active » Needs work

The "more" link seems to be untranslatable, despite the efforts in #3-6 above.

esmerel’s picture

Status: Needs work » Closed (fixed)

IF there's a problem resulting from the original committed patch, that needs to be a new issue.