Option to show term name next to image.

tjharman - January 2, 2009 - 16:59
Project:Taxonomy Image
Version:6.x-1.5
Component:Contrib Node Display
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

When I tick this option with the new in version 6.x-1.5, I also get text next to the image that's the taxonomy name of the link.

Is this text supposed to appear? The image is linked correctly to the taxonomy, but the text is unwanted.

Can provide a screencap if necessary.

Tim

#1

tjharman - January 2, 2009 - 17:08
Component:Code» Contrib Node Display

#2

e_log - January 2, 2009 - 18:18

I think some wrong code in taxonomy_image_node_display.module is the cause of this problematic behavior:

/*
* Theming function to allow overrides at theme level
*/
function theme_taxonomy_image_display($image, $term) {
  return l($image, 'taxonomy/term/'. $term->tid, array('html' => TRUE, 'attributes' => array('class' => 'taxonomy_image_links'))) . $term->name;
}

. $term->name needs to be removed.

#3

tjharman - January 2, 2009 - 19:09

Thank you - removing that code fixes the problem.

#4

NancyDru - January 2, 2009 - 21:13

#5

tjharman - January 2, 2009 - 22:18

Thanks NancyDru. I reported it only because it seemed "wrong" to me. If this is the intended behaviour, this bug can be closed.

Thanks,
Tim

#6

NancyDru - January 2, 2009 - 23:24
Title:When "Link displayed Taxonomy Image to taxonomy/term/n page" is checked, text also appearing next to image.» Option to show term name next to image.
Category:bug report» feature request

It seems that perhaps it should be an option.

#7

scrubba - January 29, 2009 - 03:25

Oh this one had me stumped for ages.
It appeared after a full upgrade and I thought it was a CKK or views 2 issue.

I am very happy I found this thread,
and
thanks for posting the fix
and
I agree very much that this should be an option.

#8

NancyDru - January 30, 2009 - 02:45

It will be when I have the time to get to it (unless someone wants to pay for it, which would bump its priority).

#9

NancyDru - February 1, 2009 - 20:14
Status:active» fixed

Committed to both branches.

#10

NancyDru - February 12, 2009 - 18:41
Status:fixed» closed

Clearing the queue a bit.

 
 

Drupal is a registered trademark of Dries Buytaert.