Closed (outdated)
Project:
ShareThis
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Jan 2009 at 06:34 UTC
Updated:
1 Oct 2019 at 08:27 UTC
Jump to comment: Most recent
Comments
Comment #1
robloachI've noticed that if the ShareThis server cannot be accessed, it doesn't work. 1.4 Seems to be working here.... Make sure you re-visit the settings.
Comment #2
otmg commentedI upgraded from 1.3 to 1.4 last night, and the same thing happened, ShareThis stopped showing up. Checked all settings, permissions, etc. Disabled, Re-enabled, etc, no dice. Had to revert to 1.3.
I am still at Drupal 6.6, going to upgrade to 6.8 soon, maybe that will fix it?
Comment #3
scott859 commentedThanks for the feedback on this. otmg, it's unfortunate that you experienced the same issue but that helps me knowing that when you reverted to 1.3 it showed up again. May I ask, since there is not an "uninstall" available with this module, what you did do get back to 1.3? Was it as simple as deleting the 1.4 ShareThis directory and replacing it with the 1.3 ShareThis directory? Or did you have to delete the tables associated with the module before reverting back to 1.3?
Thanks,
Scott
Comment #4
otmg commentedWell, i can't say that how i did it is the best practice, but yes, I disabled the 1.4 version of the module, deleted it, copied the 1.3 version to the server, enabled it, and then ran update.php just in case. All seems to work just fine.
Comment #5
robloachI just tried 1.4 on a fresh Drupal install and it's working fine. Be sure to re-save your settings and try getting a new code from ShareThis. Also be sure to clear your cache too. Oh, and check the user permissions page too....
Comment #6
robloachI'd like to release 6.x-1.5 because it does some crazy awesome behavior stuff. Would you guys mind just testing out 6.x-1.x-dev a bit?
Comment #7
scott859 commentedHey Rob,
I will do, thanks.
An odd thing happened with the 1.4 version, as I indicated in this issue it has stopped showing up for (well, not sure how long - but at least a week or two) and then STARTED showing up again. I hadn't changed any settings in the module, I'm not sure why it began showing up again, apparently the issue was related to some other module/setting in Drupal, and as it was changed it affected the ShareThis visibility on my site. I noticed ShareThis showing again after installing the Advanced Forum module, but again I am not certain of any connection there. The good thing, for me, is that it is visible again.
Thanks for your help and suggestions on this.
Scott
Comment #8
otmg commentedsure i'll test it out
Comment #9
robloachHmmmmmmmmmm............. 6.x-1.x-dev works when JavaScript is in the header, but not when it's at the bottom of the page. Not sure why....
Comment #10
kelvinwong commentedI have had a quick look inside the moudle, it seems like drupal_set_html_head($code) in function sharethis_add_js() is not setting the html head properly. Not sure whether that is a drupal things or not.
However, according to http://drupal.org/node/348964#comment-1164062, this might not be the right approach anyway.
Here is my little track, I added the following line in the <head> area on page.tpl.php and it works for me.
Comment #11
kelvinwong commentedOh sorry, I just realize that I have the <? print $head; ?> missing in my page.tpl.php, and that was the cause my problem
Comment #12
robloachYay!
Comment #14
anantagati commentedI have same problem. It was working before and now we found it doesn't show window anymore.
In Javascript console there is error:
shareel is nullComment #15
rHOnDO commentedI have two test environment with Drupal 6.16 and the ShareThis module. One environment runs ShareThis 6.1.7 and 6.1.8 without issue. The second will not run ShareThis with either version, generating a JavaScript error:
Error: shareel is null
Source File: http://w.sharethis.com/button/sharethis.js#ref=jquery&button=false
Line: 1
I've tried most of the proposed remedies here, so I am wondering if anyone has some insight that would help.
Thanks
rHO
UPDATE: I've tried using the same theme (Zen) and switched out all the modules that differ between the two installs ... this is just a conundrum.
rHO
UPDATE2: Bingo! Turns out that I get the exact same behavior with both installs and appears to be an issue with ShareThis 6.1.8. If I try to upgrade from ShareThis 6.1.7 to 6.1.8 and run update.php, it breaks on both installs, if I don't run update.php, it works fine. (I must have failed to run update.php in my previous observation.)
If I drop back to ShareThis 6.1.7 without again running update.php, it fails to work, if I do run update.php, it starts working again.
rHO
UPDATE3: /me sighs ... Well, it works in my primary browser, Firefox 3.6. It still does not work in IE8, IE7 or IE6 ... I'm too tired to test Chrome, Safari and Opera. The error in IE is below:
Webpage error details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; GTB5; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; OfficeLiveConnector.1.4; OfficeLivePatch.1.3)
Timestamp: Thu, 1 Apr 2010 23:11:23 UTC
Message: 'window.frames.stframe.location' is null or not an object
Line: 1
Char: 25729
Code: 0
URI: http://w.sharethis.com/button/sharethis.js#ref=jquery&button=false
rHO
UPDATE4: Does not work in Chrome, does not work in Safari, does not work in Opera.
rHO
Comment #16
avpadernoI am closing this issue, as Drupal 6 is no longer supported. Please re-open it if the issue is still relevant for the Drupal 7 or 8 version of the module.