number_format() problems with multibyte characters used as decimail point and/or thousands separators

hmm... the problem with multiple byte characters may also happen with the decimal point. For some reason I thought I fixed this, but it seems I forgot to do it. :(

Well, try this code to see how it can also fail with decimal points:

$number = 12345467.89;
$decimal_points = array(
  "\x2E" => t('full stop (.)'),
  "\x2C" => t('comma (,)'),
  "\xD9\xAB" => t('arabic decimal separator (٫)'),
);
$thousands_seps = array(
  '' => t('none'),
  "\x2E" => t('full stop (.)'),
  "\x2C" => t('comma (,)'),
  "\x27" => t("apostrophe (')"),
  "\xC2\xA0" => t('no-break space ( )'),
  "\xEF\xBC\x8C" => t('full width comma (，)'),
  "\xD9\xAC" => t('arabic thousands separator (٬)'),
  "\xE1\x8B\x88" => t('ethiopic syllable wa (ወ)'),
);
print '<table><tr><th></th>';
foreach ($decimal_points as $decimal_point_char => $decimal_point_name) {
  print '<th style="text-align:right">'. $decimal_point_name .'</th>';
}
print '</tr>';
foreach ($thousands_seps as $thousands_sep_char => $thousands_sep_name) {
  print '<tr>';
  print '<td style="text-align:right">'. $thousands_sep_name .'</td>';
  foreach ($decimal_points as $decimal_point_char => $decimal_point_name) {
    $str1 = number_format($number, 2, $decimal_point_char, $thousands_sep_char); // This one fails!
    $str2 = str_replace(array('X', 'Z'), array($decimal_point_char, $thousands_sep_char), number_format($number, 2, 'X', 'Z'));
    print '<td style="text-align:right">'. $str1 .'<br />'. $str2 .'</td>';
  }
  print '</tr>';
}
print '</table>';

Your change in the way decimal places are counted does not work because it counts trailing zeros to the right of the decimal part. That's why I used preg_replace.

Try this to see what I mean:

$numbers = array(
  123456789,
  12345678.9,
  1234567.89,
  123456.789,
  12345.6789,
  1234.56789,
  123.456789,
  12.3456789,
  1.23456789,
  .123456789,
);
foreach ($numbers as $number) {
  $number = sprintf('%f', (float)$number);
  $decimals = (($pos = strpos($number, '.')) === FALSE ? 0 : strlen($number) - $pos - 1);
  print $number .' -&gt; '. $decimals ."<br />";
}

Could you please try this one?

Oops! Another patch, that also fixes an issue than may happen when the input number in an integer but -1 is passed to display a variable number of decimal places.

Commited to CVS, with slight variations. Thanks