Default values

splash112 - January 3, 2009 - 17:32
Project:Simplenews Digest
Version:5.x-1.0
Component:Code
Category:feature request
Priority:minor
Assigned:Unassigned
Status:needs work
Description

Getting to like patching ;-)

Small patch which gets the default values for thing like promoted, sticky, published, comments, revision, receipt and priority from settings pages. Might not be ideal for all situations, but I would prefer it to the hard coded situation before.

Thanks
Mark

AttachmentSize
simplenews_digest_module_default_values.patch1.83 KB

#1

Steve Dondley - January 3, 2009 - 17:59
Status:needs review» needs work

I'm not sure this is a good idea. The default newsletter should have its own distinct settings from the default settings. These should be set on the default newsletter settings page.

#2

splash112 - January 4, 2009 - 02:55

Ah sorry, maybe I didn't make myself clear (and the code btw)

Comments, published, promoted, sticky and revision are taken from:
/admin/content/types/simplenews
the default newsletter settings pages

Priority and receipt are taken from:
admin/content/newsletters/settings
The newsletter settings pages

#3

Steve Dondley - January 4, 2009 - 04:57

Well, what if I want the digest newsletter to be unpublished and all the other newsletters to be published by default? I could do it but I'd be forced to change the published setting every time I created a newsletter manually.

It would be better if I had a section on the digest newsletter page where I could set these default settings for the special digest newsletter.

#4

Steve Dondley - January 4, 2009 - 04:58

Also, at some point I want to allow multiple digest newsletters. Then it will be even more important to allow each digest newsletter to have its own settings.

#5

splash112 - January 4, 2009 - 05:46

Hi Steve,

Agreed, It should be on the page. Will check what I can do about that later.
Would be, btw, more then willing to help to make multiple newsletters possible.

Do I hear a 5.2 branch?

#6

Steve Dondley - January 4, 2009 - 07:47

I was planning on doing a d6 version first.

One thing to be aware of is that the d5 simplenews module has (or had) a problem with sending multiple newsletters at the same time.

 
 

Drupal is a registered trademark of Dries Buytaert.