Posted by splash112 on January 3, 2009 at 5:32pm
Jump to:
| Project: | Simplenews Digest |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Getting to like patching ;-)
Small patch which gets the default values for thing like promoted, sticky, published, comments, revision, receipt and priority from settings pages. Might not be ideal for all situations, but I would prefer it to the hard coded situation before.
Thanks
Mark
| Attachment | Size |
|---|---|
| simplenews_digest_module_default_values.patch | 1.83 KB |
Comments
#1
I'm not sure this is a good idea. The default newsletter should have its own distinct settings from the default settings. These should be set on the default newsletter settings page.
#2
Ah sorry, maybe I didn't make myself clear (and the code btw)
Comments, published, promoted, sticky and revision are taken from:
/admin/content/types/simplenews
the default newsletter settings pages
Priority and receipt are taken from:
admin/content/newsletters/settings
The newsletter settings pages
#3
Well, what if I want the digest newsletter to be unpublished and all the other newsletters to be published by default? I could do it but I'd be forced to change the published setting every time I created a newsletter manually.
It would be better if I had a section on the digest newsletter page where I could set these default settings for the special digest newsletter.
#4
Also, at some point I want to allow multiple digest newsletters. Then it will be even more important to allow each digest newsletter to have its own settings.
#5
Hi Steve,
Agreed, It should be on the page. Will check what I can do about that later.
Would be, btw, more then willing to help to make multiple newsletters possible.
Do I hear a 5.2 branch?
#6
I was planning on doing a d6 version first.
One thing to be aware of is that the d5 simplenews module has (or had) a problem with sending multiple newsletters at the same time.