Closed (won't fix)
Project:
Audio
Version:
5.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
27 Oct 2005 at 05:08 UTC
Updated:
7 Mar 2008 at 19:47 UTC
The URL stored in the RSS enclosure doesn't work because it is absolute. Not sure why this is, but it probably shouldn't be a direct link anyhow. The following patch replaces the raw link to the audio file with the audio/download/[nid] path that is more secure and will fix the broken RSS feed.
| Comment | File | Size | Author |
|---|---|---|---|
| audio.module.rss.patch | 892 bytes | zirafa |
Comments
Comment #1
Colin Brumelle commentedFarsheed,
I've had trouble in the past with some podcast clients not playing the file unless it was a full absolute URL ending in '.mp3' Talk about inflexible! I think this problem was with both iPodder and iTunes. I'm not sure of a good way around this... What client did it not work on for you?
C
Comment #2
zirafa commentedI'm not sure why this was happening - here is an example though:
go to:
http://playlist-demo.drupalart.org/audio/feed
and then cut and paste one of the file enclosures into a new browser window, i.e.:
http://playlist-demo.drupalart.org/files/audio/SUPERWOMANPREV.mp3
and it will say "page not found". however, if you click the audio/download link for the file, it works. straaange.
Could this be a problem with the CHMOD settings for the files/audio folder? If so, is there any way the audio module could set the permissions when those folders are created?
-Farsheed
Comment #3
oliver soell commentedColin, regarding itunes not accepting podcast items without the url ending in mp3 - I changed my "rss item" nodeapi switch to return the url /audio/download/<x>/sillyitunes.mp3 and that seemed to do the trick.. when you put this into a browser (safari at least) it will play it inline rather than downloading it (just checked, firefox will download), but it does indeed work in itunes as a podcast.
Comment #4
Colin Brumelle commentedChanging the url to something like /audio/download//sillyitunes.mp3 is a good idea. I'll try playing with this a bit...
Comment #5
Colin Brumelle commentedOK,
So I just made it so that regardless of URL settings, (public or private download settings) or if you have clean URL's on or off, the complete and absolute URL of the mp3 is put into the enclosure tag in the feed. The reason is that upon reflection, I don't see a real difference security wise between having something like:
http://mysite.com/audio/dowload/1/mysong.mp3
or
http://mysite.com/files/audio/mysong.mp3
Both give you the audio file!... And the latter seems simpler and less error prone for flakey podcast clients.
This change is in CVS now. Comments? Does this make sense?
Comment #6
julianp commentedDear Colin,
Just a quick description of how I got here. I couldn't get iTunes to download the mp3. I checked out the feed that was being generated, and it was adding an enclosure that was going directly to the file (http://whatever.com/files/audio/whatever.mp3). When I typed the url into my browser, I get: Page Not Found.
I tracked down the line of code that generated the enclosure, and I modified the audio_nodeapi method to read:
Now the enclosure reads: http://whatever.com/audio/download//whatever.mp3
And it works in iTunes.
Are you going to keep using the absolute, file url for enclosures? Because that does not work on my setup, and I'm not sure why.
Thanks!
Julian
Comment #7
julianp commentedSorry, silly html escaping:
Sentence in above post should read:
Now the enclosure reads: http://whatever.com/audio/download/<node-id>/whatever.mp3
Comment #8
drewish commentedi just added some code to do this in the 4.7/HEAD branch.
Comment #9
drewish commentedi'm pretty sure this was fixed.
Comment #10
(not verified) commentedComment #11
Treesong commentedThis patch (at least I think I've tracked it down to this patch) actually appears to be causing me trouble. (I originally posted about this at http://drupal.org/node/71922 before I figured out what the problem was.)
I have Clean URLs disabled. Therefore, my RSS feed has generated URLs for the individual MP3 files that contain a question mark / query. In other words, it produces URLs such as:
http://treesong.org/yourcommunityspirit/?q=audio/download/10/file.mp3
These URLs work fine in my browser, but they cause iTunes to reject the feed. A direct link to the file works, but this indirect link doesn't seem to work. Maybe it would work without the question mark, but I'm not sure of the best way to edit the code to change the way that it's creating the URL for each MP3 file.
Any ideas on how to fix this?
Comment #12
drewish commentedwell, lets open this back up then.
Comment #13
zirafa commentedI believe iTunes doesn't play nice with ?q= strings. Frankly, iTunes is a bit of a finicky beast.
Comment #14
drewish commentedComment #15
Ricco commentedI just installed the audio module, and am trying to create an iTunes RSS feed from a audio content type. I have used the audio view to try to create the feed, and have changed to iTunes feed were able.
I get a valid feed, but the problem is that the enclosue and GUI address in the RSS feed are;
http://mysite.com/audio/download/407/audiofile.mp3
And the iTunes subscription craps out. If I change the URL to;
http://myside.com/files/audio/audiofile.mp3
The iTunes subscription will work.
The RSS will work via a browser, but iTunes cannot make sense of it. If I go in and change the URL from the two references above to the second URL, then the feed will work. I have tried both HTTP and private file storing, and I just can't figure out what I am doing wrong. Am I using a wrong field in the fields in the view? Any help would be appreciated
Cheers! Ricco
Comment #16
mfbThere could be something unusual about your file, filename or something else causing the problem.. itunes subcription is working ok for me.
Comment #17
Sakrecoer commentedand how do i install that patch?
filename of the file to be edited and line number would be greatly appreciated! :)