Closed (fixed)
Project:
Deadwood
Version:
6.x-1.4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
4 Jan 2009 at 13:11 UTC
Updated:
11 Apr 2009 at 15:20 UTC
For .install files, deadwood keeps the "// $Id..." line at the top of the file, but in case any other file comment is made, it will be moved below hook_schema(), which is wrong. Example: original .install file structure:
// $Id: versioncontrol.install,v 1.39 2009/01/03 13:21:28 jpetso Exp $
/**
* @file
* Version Control API - An interface to version control systems
* whose functionality is provided by pluggable back-end modules.
*
* Copyright 2006 by Karthik ("Zen", [url devastated by input filter])
* Copyright 2006, 2007 by Derek Wright ("dww", [url devastated by input filter])
* Copyright 2007, 2008, 2009 by Jakob Petsovits ("jpetso", [url devastated by input filter])
*/
/**
* Implementation of hook_install().
*/
function versioncontrol_install() {
(...)
}
/**
* Implementation of hook_uninstall().
*/
function versioncontrol_uninstall() {
(...)
}
After running deadwood on it, the file looks like this:
// $Id: versioncontrol.install,v 1.38 2009/01/02 21:27:31 jpetso Exp $
/**
* Implementation of hook_schema().
*/
function versioncontrol_schema() {
(...)
}
/**
* @file
* Version Control API - An interface to version control systems
* whose functionality is provided by pluggable back-end modules.
*
* Copyright 2006 by Karthik ("Zen", [url devastated by input filter])
* Copyright 2006, 2007 by Derek Wright ("dww", [url devastated by input filter])
* Copyright 2007, 2008, 2009 by Jakob Petsovits ("jpetso", [url devastated by input filter])
*/
/**
* Implementation of hook_install().
*/
function versioncontrol_install() {
(...)
}
/**
* Implementation of hook_uninstall().
*/
function versioncontrol_uninstall() {
(...)
}
There could probably be heuristics for such file header comments, I think that aspect works correctly for .module.
Comments
Comment #1
solotandem commentedFixed in tonight's dev release.