Posted by bwooster47 on January 5, 2009 at 1:57am
Jump to:
| Project: | Spam |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (duplicate) |
Issue Summary
I noticed that many of the spam connections to my site end with with empty string for IP hostname, and this ends up in the Spam modules table titled "Spam Module Blocked IPs" - which now has a row with an blank IP address, but valid last seen and very high count columns.
Just wondering if this would cause a problem - since the count is high, does this mean any connection that does not provide a hostname will now be blocked immediately?
Comments
#1
Marking this is a bug report -- I'm seeing this at well, and have not yet tracked down the implications. I assume yes, anyone not providing a hostname will be blocked immediately. Another question: do valid users not provide their hostname? In other words -- is this a bug or a feature?
#2
I think we just fixed this as #937384: spam_content_update() is broken - inconsistent hostname derivation.
#3
Just wondering, would it be worth considering deleting the row with the empty IP address? It may wrongly detect some entries?
#4
I think Jeremy had a good point with the "is it a bug or a feature?" question. Assuming the empty IP address correctly matches to an empty IP address and to nothing else (and I think it would likely have been obvious if it did; it'd probably start matching to everything if it didn't match to just blanks), it stands to reason that an unreported IP address, if it is commonly associated with spam, will remain likely to be associated with spam in the future.