I just assumed that og_vocab never had the ability to hook into pathauto and update taxonomy aliases--but it seem rather that the og_vocab.pathauto.inc file is rather outdated. The new pathauto uses the token module, so the hook_pathauto_taxonomy does not seem to be working.

CommentFileSizeAuthor
#9 og_vocab.pathauto.inc_.txt736 bytesamitaibu
#6 og_vocab.pathauto.inc_.txt774 bytesjoewang
#5 og_vocab.pathauto.inc_.txt786 bytesjoewang
#3 og_vocab.pathauto.inc_.txt811 bytesjoewang

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Yes, I've only moved the pathauto to an include file. Patches are welcome.

joewang’s picture

joewang commented

I don't really have much time to work on a large patch, but here's what I found in the issue queue of the category module:

http://drupal.org/node/254231

Maybe it will help with og_vocab here? This issue isn't very urgent, but would be nice to solve.

joewang’s picture

joewang commented
Status: Active » Needs review
StatusFileSize
new og_vocab.pathauto.inc_.txt811 bytes

You know what, I wrote the patch all by myself ;)

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Needs work

Great, thanks.
There are tabs on the patch - please re-roll following the coding standards - http://drupal.org/coding-standards

joewang’s picture

joewang commented
StatusFileSize
new og_vocab.pathauto.inc_.txt786 bytes

How's this? code-check.pl didn't say anything when run.

joewang’s picture

joewang commented
StatusFileSize
new og_vocab.pathauto.inc_.txt774 bytes

Whoops-here we go.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Some fine tuning:
1) Please roll a patch using diff - http://drupal.org/patch/create
2) I actually still didn't commit, because I'm missing some comments to explain the code.
3) $category = $object; why do we need $category, can't you just use $result = db_query($sql, $object->vid);

Thanks :)

joewang’s picture

joewang commented

1. I know how to use diff--I just don't see why you'd need a patch since the new include is essentially a different file.
2. The old include didn't have any comments either. I think the code is pretty self explanatory.
3. I followed the convention used in the pathauto module. They had $node = $object; and ....$node....

Anyways, some of these changes you request are rather minor--couldn't you just do them before committing? I'm using the new include on my site with no problems, so I really don't really feel obligated to fine tune what I have.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs work » Needs review
StatusFileSize
new og_vocab.pathauto.inc_.txt736 bytes

About the diff no problem.
As I'm not using pathauto, I submit the patch for your review. btw, in comments I meant things like 'implementation of ...' - which result with a nicer code :)

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Assigned: Unassigned » amitaibu
Status: Needs review » Needs work

hmm ,actually this inc should be called og_vocab.token.inc - as it's mostly a token implementation. I'll work on it.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Title: og_vocab pathauto hasn't been working all along » Token integration doesn't work
Status: Needs work » Fixed

http://drupal.org/cvs?commit=163447

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.