Non-unique id, simplification of theme function

AlexisWilke - January 5, 2009 - 06:16
Project:Link To Us
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:AlexisWilke
Status:needs review
Description

Hi Gman,

Thank you for your really fast replies! 8-)

I have one more request. This one is bigger/harder. When I looked at the code, I noticed that all the input tags had the same identifier (linkurl) which is wrong HTML. So I started to implement a fix and noticed that the theme function could also be simplified if you were to move the help in the $links array.

And to add to the CSS capabilities, I put the entire group of things within one DIV tag called content and link-to-us.

Also, I think that all your classes should start with link-to-us just so you don't bump in someone else class. (I think that's also a Drupal request to do that.)

Okay, that works for me 8-)

See my site here:

http://www.turnwatcher.com/link_to/node/1

Really cool when I think that works for nearly all the pages of the site! (if that was to work on views...)

Thank you.
Alexis Wilke

AttachmentSize
link_to_us-6.x-1.x-ids.patch3.16 KB

#1

AlexisWilke - January 7, 2009 - 21:31

Ooops! Small bug in my patch.

I missed one period! I'm posting a new one.

Sorry about that!
Alexis

AttachmentSize
link_to_us-6.x-1.x-ids.patch 3.15 KB
 
 

Drupal is a registered trademark of Dries Buytaert.