I get the message 'Undefined variable: nodes in ....nodequeue.module on line 1976' whenever I try to save my nodequeue. In looking at the code on that line, there is:

if ($nodes) {
...
}

But there is not variable called $nodes defined anywhere in that function. I tried to figure out what was supposed to be happening there, but couldn't. I went back into the D5 code to see what was happening there, and found the same code and again no value for $nodes. In D5 it would have silently skipped that step, but D6 doesn't like it.

It looks like a bug in both versions. Since that code will not actually do anything in either version, I'm guessing it would be safe to just remove the whole thing, but I wonder why it was put there in the first place.

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Fixed

Indeed. It looks like that that conditional was added around that query to prevent it from running, but it shouldn't exist in this function at all since nodequeue_save saves the queue object, not the queue order.

Removed from both the D5 and D6 versions. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.