Full text search cannot match comments [#35454]

Near the top of node_trip_search it adds the MATCH clause to $query->wheres if mysql_full mode is in use. If comment module is present it adds subject/comment to $query->fields. When the query is put together you get all the fields OR'ed together (match if any specified field matches) but the MATCH is AND'ed in.. ie, even if a comment matches it won't return that topic unless the MATCH clause also evaluates to true. When fulltext is not in use you get node title/body in $query->fields so everything is properly OR'ed together.

Comment	File	Size	Author
#9	trip_search.module_diff.txt	9.57 KB	mindless
#4	trip_search.module_patch_0.txt	12.84 KB	mindless
#3	trip_search.module_patch.txt	12.77 KB	mindless
#1	trip_search.module_fulltext_patch.txt	2.67 KB	mindless

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mindless CreditAttribution: mindless commented 27 October 2005 at 17:47

Version:	4.6.x-1.x-dev	» master
Status:	Active	» Needs review

File	Size
trip_search.module_fulltext_patch.txt	2.67 KB

Here is my quick fix for this problem.. it now ORs the MATCH clause with the clauses generated by $query->fields. Patch is against current CVS. Hope this helps..

Comment #2

mindless CreditAttribution: mindless commented 27 October 2005 at 17:51

Hm, I suppose rather than:

if ($query->fields || $query->match) {
  $query = trip_search_expand_query($query, $keys);
}

this would be more appropriate:

if ($query->fields) {
  $query = trip_search_expand_query($query, $keys);
}
else if ($query->match) {
  $query->wheres[] = $query->match;
}

Though since with the current code $query->fields is never empty, this doesn't really matter.

Comment #3

mindless CreditAttribution: mindless commented 27 October 2005 at 23:47

File	Size
trip_search.module_patch.txt	12.77 KB

The previous patch created significant performance problems now that the LEFT JOIN on comments table must actually be processed. We now use a new fulltext index on comments table (subject,comment) and a separate query to check comments. New patch against cvs is attached. Note this patch also includes some fixes we use for proper escaping of quotes (though we run 4.6; hopefully I got everything right in this cvs patch). Note the "filter results by category" counts are still based only on node matches; comment matches not counted.

Comment #4

mindless CreditAttribution: mindless commented 28 October 2005 at 22:48

File	Size
trip_search.module_patch_0.txt	12.84 KB

..and one more update to the patch to fix another bug.. user:"user name" syntax (this syntax is generated by advanced search but then not parsed correctly).

Comment #5

nedjo

he/him/his

English

CreditAttribution: nedjo commented 9 November 2005 at 19:08

Thanks for the improvements, apologies that I haven't found a chance to test this. Would you be willing to fix any new bugs that the patch may raise? If so, please go ahead and apply it.

Comment #6

mindless CreditAttribution: mindless commented 17 March 2006 at 06:21

Status: I applied the user:"user name" fix mentioned in comment #4. nedjo has already applied some of the other search-term-parsing fixes. These parts of the patch above are now in CVS:
@@ -307,7 +307,7 @@
@@ -554,6 +554,7 @@
@@ -700,18 +701,15 @@
Now the remaining parts of the patch file relate just to this bug report :-)

Comment #7

joel_guesclin CreditAttribution: joel_guesclin commented 16 October 2006 at 10:18

I've taken on trip_search in 4.7 - but ran into the same problem with comments and for the moment have removed it altogether. Is there any interest in looking at this subject again? The code has changed a lot though...

Comment #8

mindless CreditAttribution: mindless commented 23 October 2006 at 20:55

we've had to disable search.module due to performance problems, so yes we'd certainly be interested if trip_search worked on 4.7 and could search comments.

Comment #9

mindless CreditAttribution: mindless commented 24 January 2007 at 01:58

Status:

Needs review

» Needs work

File	Size
trip_search.module_diff.txt	9.57 KB

my work-in-progress, if you'd like to take a look.

Comment #10

joel_guesclin CreditAttribution: joel_guesclin commented 24 January 2007 at 13:26

Assigned:

Unassigned

» joel_guesclin

Thanks - I am waiting for approval for a new version which will have changed a fair bit once again, in order to overcome XSS vulnerability. Once that is available, if you would like to have a look again at including comments I would certainly be interested.