Download & Extend

Test function_exists('imageapi_menu') breaks install profiles

Project:ImageCache
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:alex_b
Status:closed (fixed)

Issue Summary

Similar to #354719: Call to imageapi_get_available_toolkits() breaks install profiles :

The test for function_exists('imageapi_menu') fails when installing in a profile and thus breaks install profiles. It's not obvious to me how to fix this, I will work without this check for the time being...

Comments

#1

Status:active» postponed (maintainer needs more info)

need more info... where is this being called. a patch would be great.

#2

Sorry, called in imagecache.install imagecache_requirements() when installed with an install profile:

  if (!function_exists('imageapi_menu')) {
    $requirements['imagecache_imageapi'] = array(
      'title' => $t('ImageAPI'),
      'value' => $t('Missing'),
      'severity' => REQUIREMENT_ERROR,
      'description' => $t('Imagecache requires ImageAPI to function.'),
    );
  }

I'd be happy to roll a patch but I am not quite sure what approach to take here. It's not clear to me why this test exists at all when imagecache depends on imageapi anyway (see .info file).

#3

Assigned to:Anonymous» alex_b

I am going to roll 2 patches: one removes the check, the other one moves it to $phase == 'runtime'

#4

Here you go, both applicable to latest DRUPAL-5--2. Both address the problem that imagecache barfs on install profile installation.

AttachmentSizeStatusTest resultOperations
354724_remove_check.patch867 bytesIgnored: Check issue status.NoneNone
354724_check_on_runtime.patch1.33 KBIgnored: Check issue status.NoneNone

#5

Status:postponed (maintainer needs more info)» needs review

Needs review.

#6

Status:needs review» fixed

thanks, committed to DRUPAL-5--2.

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.