Download & Extend

Incorrect boolean comparison breaks Postgres

Project:Taxonomy dhtml
Version:4.7.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The current version of the 4.6.0 code passes an integer value to a boolean comparison, which isn't valid. MySQL will ignore that and automatically cast to bool, but Postgres will not. The attached patch fixes this.

AttachmentSize
taxonomy_dhtml_boolean.patch773 bytes

Comments

#1

can anyone confirm that mysql doesn't compain about this?

#2

Version:4.6.x-1.x-dev» 4.7.x-1.x-dev

Well, this bug is still there, and I found a new location as well which actually has to be solved by an explicit cast. New patch attached which corrects both.

AttachmentSize
taxonomy_dhtml_bool.patch 1.32 KB

#3

Status:needs review» fixed

That CAST() is not working in MySQL. But "WHERE true" works everywhere i think. However, this will be fixed in 5.x-2.x release

#4

Status:fixed» closed (fixed)
nobody click here