The module requires that drupal variable site_403 is set to r4032login. However the module does not do this automatically, and it is not clearly or documented in many places. (It would be useful on admin > reports > status and on the project page).

This patch sets drupal variable site_403 to r4032login on install, and restores it to it's previous setting on uninstall. It also removes the documentation in README.txt that is made redundant by these changes.

CommentFileSizeAuthor
#6 354826.patch1.95 KBBevan
r4032login-install.patch1.78 KBBevan

Comments

Mark Theunissen’s picture

Mark Theunissen commented

Great idea, took a brief look at the code and it seems fine.

frank ralf’s picture

frank ralf commented

Great improvement! Took me at least 10 minutes to figure that setting out while scratching my head why the module didn't work... Will try the patch and report here.

Frank

xmoe’s picture

xmoe commented

Great improvement! But I would rather use the functions hook_disable() and hook_enable() instead of hook_install() and hook_uninstall().

xmoe’s picture

xmoe commented

it would probably be even better to alter the system_error_reporting_settings-form and replace the 403-textfield with a message saying that 403 is handled by this module.

webwriter’s picture

webwriter commented

Thank you for this info! I really needed it.

Bevan’s picture

Bevan commented
StatusFileSize
new 354826.patch1.95 KB

I made the changes in enable/disable hooks, as recommended.

In order to keep the patch lean and simple, I didn't do the form alter stuff. Though I agree this is a good idea, for another issue/patch.

Bevan’s picture

Bevan commented

Bump. Reviews? Commits?

deekayen’s picture

deekayen commented
Status: Needs review » Closed (duplicate)

#318935: Cannot get module to work