Phone field is truncated

Marcel,

thanks for your report. And sorry for not fixing it yet. I launched the new versions because it was important security bugs. Now im working on other bugs.

Location module is more focused on Geocode and map integration. Thats why Location has 1.64 MB and Addresses has only 70 KB. Also the Location's issues list is substantially bigger.

since i change the internal API (by november) and the final release of CCK changed the API too, the CCK support became quite bogus. I will make a sprint to fix it. Some other issues were open to report this. Its my priority.

Phone fields are also reported http://drupal.org/node/346267. I will focus there the communication ok?

best regards,

massa

Marcel,

the phone problem is now solved. Soon on the 1.03 release.

regards,

massa

Marcel,

take a look on http://drupal.org/node/355595. i wrote a mini tutorial. It would be great to correct Romanian data.

regards,

massa

I just notice that the Phone field still does not show up in version 6.x-1.05.
(nothing displayed at all)

Also, it troncatates the phone number to 16 digits, which does not allow to include country code and spaces

I reopened the issue

The specific instance of this problem I was having was with displaying a Phone number by itself in views; whether as a table or a node, I couldn't get the Phone number to display at all. After poking around I patched the module to fix this issue (see attached). However, there are two clear issues still to be addressed:

1. Other fields, like city, postal code, etc., need similar patches in order to display properly (some brief testing confirms my suspicion that they don't show up in views either)

2. I'm fairly sure that the specific code I use to display phone numbers is probably not up to snuff, whether for security reasons or otherwise.

Once item 2 is addressed, I'm pretty sure item 1 will be quite easy to fix. It's also possible that my approach in this patch is totally off, but after chasing quite a few tails in this debugging session, I'm reasonably sure this is the "right" approach.

Whoops! Sure would help to post the patch files themselves. Here they are.

When can we get these fixes committed in a new version?

Thanks

Ive applied the patches, but the phone numbers still dont show, even after putting in an entirely new entry.

Update: Need to add !phone and !fax to country "address formats", either default, or specific country...my boo boo ;)

Views integration is a work in progress

The phone field properly displays it just needs to be included within your address formats. I am working on a new patch which will notify the user upon installation to update their address formats.

Phone and fax fields appear to be truncated to 16 digits as described by jvieille in #10.

Pomliane,

In the database phone and fax fields are stored at 16 characters.

If you are interested in fixing this issue could you please do some research to find a valid number of characters for this field with country codes included? If you can come up with a specific number that will meet every country's requirement I will be glad to include it within the 1.07 release.

Also as a note I added a message upon install of the addresses_phone module to alert the user to update their formatting options #685390: addresses_phone install message and text fix - included in the 1.06 release.

Hi codycraven,

It seems there is an ITU-T recommendation (E.164) which states that "the entire number should be 15 digits or shorter" so 16 could sound good...
But, if we want these numbers to be human readable we should be able to add ((almost) as many) spaces (as we want).
Let the user add a bit of customization - like a couple of brackets for local calls prefix - and it should be perfect !

Source : http://en.wikipedia.org/wiki/Telephone_number

Pomliane,

It sounds like we'll need to do some further research to figure out a good number that will allow for reasonable formatting internationally. From the language on wikipedia it sounds as though the number of digits (15) does include the country code, although it is a bit ambiguous so I could be wrong.

Codycraven,

Yes : the number of digits (15) does include the country code !
BUT, with 15 or 16 digits in the DB, you can't have, say, extra spaces to make it readable, or brackets, or any formatting element...
If there is no separate table to handle formatting options (per country/default), 24 should be a good number (a good maximum at least)...

Pomliane,

24 seems like a number that will allow for almost any number of formatting options.

Down the road I would like to expand the phone/fax support to include validation and formatting which would likely need to be supported by a separate module (an API).

I will update the code and post a patch as soon as I get time to support 24 characters for the phone/fax fields.

By the way, why shall the module care about the formatting of phone/fax number?
That is more annoying than helpful... An unlimited string field would fit...

jvieille, we have to set a number of characters for optimal database operation for a field this size. If we allow users to enter a very long string then they could abuse the ability and post lots of unnecessary information to the database that could beak your theme and take up space in your database.

Hi jvieille,

Please, what would you suggest to format these fields on a per country basis ?

As suggested aboce, 24 character should be OK.
No format control.

My points:
1) why checking the format if we cannot check the correctness of the number itself?
2) A correct format is only important for computers, not for human beings. I am not aware of an API which could dial the number form Drupal to say Skype, so why bothering?

jvieille,

For the time being we will not be doing any format checking. In the future I would like to have an optional phone number formatting system which would ensure that numbers from a large user base are all formatted uniformly per country.

Moving the development of the patch to a new issue as there is a lot of unrelated data in this thread.

See #699572: addresses_phone expand to 24 characters - we need as many reviewers as possible for patches on this one!